Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for duplication in presubmits' extra_refs in checkconfig #15372

Merged
merged 2 commits into from
Nov 26, 2019
Merged

Check for duplication in presubmits' extra_refs in checkconfig #15372

merged 2 commits into from
Nov 26, 2019

Conversation

adshmh
Copy link
Contributor

@adshmh adshmh commented Nov 22, 2019

Fixes #15237

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 22, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @adshmh. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 22, 2019
@k8s-ci-robot k8s-ci-robot added area/prow Issues or PRs related to prow sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 22, 2019
@clarketm
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 22, 2019
@adshmh
Check config for duplication in extra_refs
61c35a9 
Prow config now provides a validation function for presubmit jobs to
allow checking for duplications in extra_refs field due to either:
       a) Specifying the repo for which the job is configured, or
       b) duplication among extra_refs entries.

Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>
@adshmh
Check for extra_refs duplications in checkconfig
2a07eff 
The checkconfig command now validates the extra_refs field in presubmit
jobs to make sure there are no duplications, including the specification
of the repo for which the job is configured.

Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>
@adshmh adshmh force-pushed the 15237-invalid-extra-refs-not-caught-in-presubmits branch from 653129a to 2a07eff Compare November 25, 2019 15:26
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 26, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adshmh, chases2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2019
@k8s-ci-robot k8s-ci-robot merged commit 93c6c43 into kubernetes:master Nov 26, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chases2 chases2 chases2 approved these changes

@michelle192837 michelle192837 Awaiting requested review from michelle192837

Assignees

@chases2 chases2

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

invalid extra refs not caught in presubmit
4 participants
@adshmh @k8s-ci-robot @clarketm @chases2