Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to ubuntu 18.04 image for cpu-manager tests #15609

Merged
merged 1 commit into from
Jan 28, 2020
Merged

Switch to ubuntu 18.04 image for cpu-manager tests #15609

merged 1 commit into from
Jan 28, 2020

Conversation

odinuge
Copy link
Member

@odinuge odinuge commented Dec 14, 2019

Use the same image as the other serial tests.

The old one fails during preflight check becuse docker cli
is missing some args.

eg. https://prow.k8s.io/view/gcs/kubernetes-jenkins/logs/ci-kubernetes-node-kubelet-serial-cpu-manager/1205820052486492165

@odinuge
Switch to ubuntu 18.04 image for cpu-manager tests
03190c3 
Use the same image as the other serial tests.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Dec 14, 2019
@odinuge
Copy link
Member Author

odinuge commented Dec 14, 2019

/cc @vpickard

@k8s-ci-robot
Copy link
Contributor

@odinuge: GitHub didn't allow me to request PR reviews from the following users: vpickard.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @vpickard

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@odinuge
Copy link
Member Author

odinuge commented Jan 7, 2020

/assign yujuhong

gentle ping to the others..

@yujuhong
Copy link
Contributor

yujuhong commented Jan 7, 2020

/assign @cheftako
/assign @yguo0905

@yujuhong yujuhong removed their assignment Jan 7, 2020
cheftako
cheftako reviewed Jan 8, 2020
View reviewed changes
jobs/e2e_node/image-config-serial-cpu-manager.yaml
@@ -3,7 +3,7 @@
# `gcloud compute --project <to-project> images create <image-name> --source-disk=<image-name>`
images:
ubuntu:
image: ubuntu-gke-1604-xenial-v20170420-1 # docker 1.12.6
image: ubuntu-gke-1804-d1703-0-v20181113 # docker 17.03
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use ubuntu-gke-1804-d1703-0-v20190917 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can. I have not tested that specific one tho. v20181113 is used for all the other node_e2e tests (
https://github.com/kubernetes/test-infra/search?q=ubuntu-gke-1804-d1703-0-v20181113&unscoped_q=ubuntu-gke-1804-d1703-0-v20181113), so I think it's best to bump all of them at the same time. Or what do you think @cheftako ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc vpickard

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use the latest ubuntu-gke-1804-d1903-0-* which has Docker 19.03?

@k8s-ci-robot
Copy link
Contributor

@vpickard: GitHub didn't allow me to request PR reviews from the following users: vpickard.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc vpickard

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vpickard vpickard mentioned this pull request Jan 15, 2020
Merged
@klueska
Copy link

klueska commented Jan 20, 2020

@cheftako is there anything you still see missing from this PR? It is blocking development of our node e2e tests.

@vpickard
Copy link
Contributor

@odinuge @cheftako Would it be possible to go ahead and merge this PR so we can proceed with testing?

@vpickard vpickard mentioned this pull request Jan 23, 2020
Closed
@derekwaynecarr
Copy link
Member

this is consistent with image-config-serial, so it makes sense to me.

/lgtm
/approve

the owners files here may need to be updated to include all top-level sig-node approvers.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 27, 2020
@derekwaynecarr derekwaynecarr mentioned this pull request Jan 27, 2020
Merged
@dchen1107
Copy link
Member

/lgtm
/approve

@yujuhong
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, derekwaynecarr, odinuge, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2020
@k8s-ci-robot k8s-ci-robot merged commit a3b2720 into kubernetes:master Jan 28, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheftako cheftako cheftako left review comments

@vpickard vpickard vpickard left review comments

@Random-Liu Random-Liu Awaiting requested review from Random-Liu

@yguo0905 yguo0905 Awaiting requested review from yguo0905

Assignees

@cheftako cheftako

@derekwaynecarr derekwaynecarr

@dchen1107 dchen1107

@yguo0905 yguo0905

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@odinuge @k8s-ci-robot @yujuhong @klueska @vpickard @derekwaynecarr @dchen1107 @cheftako @yguo0905