Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use an options object for GCS credentials #15663

Merged
merged 1 commit into from Apr 1, 2020
Merged

Use an options object for GCS credentials #15663

merged 1 commit into from Apr 1, 2020

Conversation

adshmh
Copy link
Contributor

@adshmh adshmh commented Dec 19, 2019

Part of work on #13084

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 19, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @adshmh. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 19, 2019
@k8s-ci-robot k8s-ci-robot added area/prow Issues or PRs related to prow area/prow/gerrit Issues or PRs related to prow's gerrit component area/prow/tide Issues or PRs related to prow's tide component sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Dec 19, 2019
@adshmh
Copy link
Contributor Author

adshmh commented Dec 19, 2019

@stevekuznetsov I limited the scope to the credentials file for the first draft, but it may be possible to factor out all statusURI, historyURI, etc. used by controllers (tide uses 2, other controllers use only 1).

stevekuznetsov
stevekuznetsov reviewed Dec 19, 2019
View reviewed changes
Copy link
Contributor

@stevekuznetsov stevekuznetsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small comments

prow/flagutil/storage.go Outdated
type StorageClientOptions struct {
// The following are used for reading/writing to GCS.
GCSCredentialsFile string
GCSOptionDescription string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: why is this public, or stored? couldn't we store a closure to bind onto a flagset or at least store the description as a private member?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review. Fixed.

prow/flagutil/storage.go Outdated
if o.GCSCredentialsFile != "" {
gcsMessage = fmt.Sprintf(" gcs-credentials-file: %s", o.GCSCredentialsFile)
}
return opener, fmt.Errorf("error creating opener%s: %w", gcsMessage, err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/%w/%v?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review. Done.

@mikesplain
Copy link
Contributor

I was just looking into doing this, anyway this can be re-reviewed @stevekuznetsov? Thanks!

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 23, 2020
@adshmh
Use an options object for GCS and S3 credentials
8227e6b 
Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 1, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adshmh, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2020
@k8s-ci-robot k8s-ci-robot merged commit f28c158 into kubernetes:master Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevekuznetsov stevekuznetsov stevekuznetsov approved these changes

@alvaroaleman alvaroaleman Awaiting requested review from alvaroaleman

Assignees

@stevekuznetsov stevekuznetsov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow/gerrit Issues or PRs related to prow's gerrit component area/prow/tide Issues or PRs related to prow's tide component area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@adshmh @k8s-ci-robot @mikesplain @stevekuznetsov