Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.18] releng: Update Slack whitelisted Branch Managers #16339

Merged
merged 1 commit into from
Feb 18, 2020

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Feb 18, 2020

Pending branch cut:
/hold

/sig release
/area release-eng
/assign @tpepper @justaugustus
/cc @saschagrunert @hasheddan

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/release Categorizes an issue or PR as relevant to SIG Release. area/release-eng Issues or PRs related to the Release Engineering subproject labels Feb 18, 2020
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 18, 2020
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2020
@cpanato
Copy link
Member Author

cpanato commented Feb 18, 2020

/priority important-soon

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Feb 18, 2020
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpanato -- Some fixes needed on this one.

config/prow/plugins.yaml Outdated Show resolved Hide resolved
config/prow/plugins.yaml Outdated Show resolved Hide resolved
config/prow/plugins.yaml Outdated Show resolved Hide resolved
config/prow/plugins.yaml Outdated Show resolved Hide resolved
config/prow/plugins.yaml Outdated Show resolved Hide resolved
config/prow/plugins.yaml Outdated Show resolved Hide resolved
config/prow/plugins.yaml Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2020
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. One more fix. Can you add me to the 1.15 and 1.16 branches?

@cpanato
Copy link
Member Author

cpanato commented Feb 18, 2020

@justaugustus done ✅

@justaugustus
Copy link
Member

/lgtm
/approve

Keep held until the branch is cut.

/assign @cblecker @krzyzacy

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2020
@cblecker
Copy link
Member

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, cpanato, hasheddan, justaugustus, krzyzacy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cpanato
Copy link
Member Author

cpanato commented Feb 18, 2020

branch created
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 18, 2020
@k8s-ci-robot k8s-ci-robot merged commit 40116f7 into kubernetes:master Feb 18, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Feb 18, 2020
@k8s-ci-robot
Copy link
Contributor

@cpanato: Updated the plugins configmap in namespace default at cluster default using the following files:

  • key plugins.yaml using file config/prow/plugins.yaml

In response to this:

Pending branch cut:
/hold

/sig release
/area release-eng
/assign @tpepper @justaugustus
/cc @saschagrunert @hasheddan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cpanato cpanato deleted the slack-branch-whitelist branch February 18, 2020 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants