Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubernetes-sigs/boskos: configure prow plugins and jobs #17647

Merged

Conversation

ixdy
Copy link
Member

@ixdy ixdy commented May 20, 2020

Configures the various plugins to support GitHub reviews, and also enable the overrides plugin (especially while getting CI set up).

I've created single presubmit and postsubmit jobs, since build/test/verify all run pretty quickly right now. I can separate these if we feel it's more appropriate.

Both the presubmit and postsubmit jobs have been tested locally with phaino and appear to work.

/area boskos
/assign @alvaroaleman @cjwagner

@k8s-ci-robot k8s-ci-robot added area/boskos Issues or PRs related to code in /boskos cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs area/testgrid sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 20, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 20, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, cjwagner, ixdy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2020
@k8s-ci-robot k8s-ci-robot merged commit 55e7bb5 into kubernetes:master May 20, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 20, 2020
@k8s-ci-robot
Copy link
Contributor

@ixdy: Updated the following 2 configmaps:

  • plugins configmap in namespace default at cluster default using the following files:
    • key plugins.yaml using file config/prow/plugins.yaml
  • job-config configmap in namespace default at cluster default using the following files:
    • key boskos-postsubmits.yaml using file config/jobs/kubernetes-sigs/boskos/boskos-postsubmits.yaml
    • key boskos-presubmits.yaml using file config/jobs/kubernetes-sigs/boskos/boskos-presubmits.yaml

In response to this:

Configures the various plugins to support GitHub reviews, and also enable the overrides plugin (especially while getting CI set up).

I've created single presubmit and postsubmit jobs, since build/test/verify all run pretty quickly right now. I can separate these if we feel it's more appropriate.

Both the presubmit and postsubmit jobs have been tested locally with phaino and appear to work.

/area boskos
/assign @alvaroaleman @cjwagner

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/boskos Issues or PRs related to code in /boskos area/config Issues or PRs related to code in /config area/jobs area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants