Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go deps: k8s.io/test-infra/boskos -> sigs.k8s.io/boskos #17721

Merged
merged 1 commit into from
Jun 2, 2020
Merged

Update go deps: k8s.io/test-infra/boskos -> sigs.k8s.io/boskos #17721

merged 1 commit into from
Jun 2, 2020

Conversation

ixdy
Copy link
Member

@ixdy ixdy commented May 27, 2020

Hopefully this doesn't create a circular dependency?

x-ref #17614, kubernetes-sigs/boskos#3

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 27, 2020
@ixdy
Copy link
Member Author

ixdy commented May 27, 2020

/area boskos

@k8s-ci-robot k8s-ci-robot added area/boskos Issues or PRs related to code in /boskos area/config Issues or PRs related to code in /config area/kubetest area/prow/bump Updates to the k8s prow cluster sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 27, 2020
This was referenced May 27, 2020
Merged
Closed
@ixdy ixdy force-pushed the add-kubernetes-sigs-boskos-dependency branch from 614f2f0 to 1cf4652 Compare May 28, 2020 21:21
@ixdy
Copy link
Member Author

ixdy commented Jun 1, 2020

/assign @chases2

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 2, 2020
@dims
Copy link
Member

dims commented Jun 2, 2020

/approve

LGTM!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, dims, ixdy, michelle192837

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2020
@k8s-ci-robot k8s-ci-robot merged commit c1964ea into kubernetes:master Jun 2, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michelle192837 michelle192837 michelle192837 approved these changes

@cblecker cblecker cblecker approved these changes

@spiffxp spiffxp Awaiting requested review from spiffxp

Assignees

@michelle192837 michelle192837

@chases2 chases2

@cblecker cblecker

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/boskos Issues or PRs related to code in /boskos area/config Issues or PRs related to code in /config area/kubetest area/prow/bump Updates to the k8s prow cluster cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ixdy @dims @k8s-ci-robot @michelle192837 @cblecker @chases2