Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark-config: use recommended Ubuntu images #18209

Merged
merged 1 commit into from Jul 10, 2020
Merged

benchmark-config: use recommended Ubuntu images #18209

merged 1 commit into from Jul 10, 2020

Conversation

bart0sh
Copy link
Contributor

@bart0sh bart0sh commented Jul 8, 2020

Used ubuntu-gke images recommended by the GKE Release Notes
https://cloud.google.com/kubernetes-engine/docs/release-notes:

  • for GKE 1.16 clusters: ubuntu-gke-1804-1-16-v20200330
  • for GKE 1.15.11-gke.17 clusters and up: ubuntu-gke-1804-1-15-v20200330
  • for GKE 1.14.10-gke.40 clusters: ubuntu-gke-1804-1-14-v20200219

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 8, 2020
@bart0sh
Copy link
Contributor Author

bart0sh commented Jul 8, 2020

/cc @dims @vpickard @MHBauer @spiffxp @bsdnet

spiffxp
spiffxp reviewed Jul 8, 2020
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW stable1 should be newest, stable3 should be oldest

ref: https://github.com/kubernetes/test-infra/blob/master/docs/kubernetes-versions.md#ci-versions

@bsdnet
Copy link
Contributor

bsdnet commented Jul 8, 2020

/assign @karan who knows Ubuntu on GKE well.

@bart0sh bart0sh force-pushed the PR0009-benchmark-config-use-recommended-ubuntu-images branch from 369683f to 7a008f0 Compare July 9, 2020 14:15
@bart0sh
Copy link
Contributor Author

bart0sh commented Jul 9, 2020

@spiffxp

FWIW stable1 should be newest, stable3 should be oldest

Fixed. Thank you for the review!

karan
karan suggested changes Jul 9, 2020
View reviewed changes
jobs/e2e_node/benchmark-config.yaml Outdated Show resolved Hide resolved
@MHBauer
Copy link
Contributor

MHBauer commented Jul 9, 2020

FWIW stable1 should be newest, stable3 should be oldest

ref: https://github.com/kubernetes/test-infra/blob/master/docs/kubernetes-versions.md#ci-versions

What a wonderful document!

Used ubuntu-gke images recommended by the GKE Release Notes
https://cloud.google.com/kubernetes-engine/docs/release-notes:

* for GKE 1.16 clusters: ubuntu-gke-1804-1-16-v20200330

* for GKE 1.15.11-gke.17 clusters and up: ubuntu-gke-1804-1-15-v20200330

* for GKE 1.14.10-gke.40 clusters: ubuntu-gke-1804-1-14-v20200219

As far as the text goes, those release notes don't seem terribly comprehensive. No mention of 1.17 for ubuntu even though such images exist.

$ gcloud compute images list --project ubuntu-os-gke-cloud --no-standard-images --show-deprecated --sort-by=creationTimestamp | tail -n 7
ubuntu-gke-1804-1-12-v20200708      ubuntu-os-gke-cloud                                     READY
ubuntu-gke-1804-1-16-v20200708      ubuntu-os-gke-cloud  pipeline-3                         READY
ubuntu-gke-1804-1-14-v20200708      ubuntu-os-gke-cloud  pipeline-1                         READY
ubuntu-gke-1804-1-17-v20200708      ubuntu-os-gke-cloud  pipeline-4                         READY
ubuntu-gke-1804-1-13-v20200708      ubuntu-os-gke-cloud                                     READY
ubuntu-gke-1804-1-15-v20200708      ubuntu-os-gke-cloud  pipeline-2                         READY
ubuntu-gke-1804-1-17-v20200709      ubuntu-os-gke-cloud  pipeline-4                         READY

This makes me think we should refer to the document linked above and regex-match on ubuntu-gke-1804-1-17 with each kube version specified

@bart0sh
benchmark-config: use recommended Ubuntu images
68bf380 
Used ubuntu-gke images recommended by the GKE Release Notes
https://cloud.google.com/kubernetes-engine/docs/release-notes:

 - for GKE 1.16 clusters: ubuntu-gke-1804-1-16-v20200330
 - for GKE 1.15.11-gke.17 clusters and up: ubuntu-gke-1804-1-15-v20200330
 - for GKE 1.14.10-gke.40 clusters: ubuntu-gke-1804-1-14-v20200219
@bart0sh bart0sh force-pushed the PR0009-benchmark-config-use-recommended-ubuntu-images branch from 7a008f0 to 68bf380 Compare July 9, 2020 16:55
@spiffxp
Copy link
Member

spiffxp commented Jul 10, 2020

/approve
/lgtm
This looks like a good start, I think @MHBauer's suggestions are valid for a followup

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bart0sh, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2020
@k8s-ci-robot k8s-ci-robot merged commit 9de6b7f into kubernetes:master Jul 10, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp spiffxp left review comments

@karan karan karan requested changes

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@dims dims Awaiting requested review from dims

@bsdnet bsdnet Awaiting requested review from bsdnet

@MHBauer MHBauer Awaiting requested review from MHBauer

@vpickard vpickard Awaiting requested review from vpickard

Assignees

@spiffxp spiffxp

@karan karan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bart0sh @bsdnet @MHBauer @spiffxp @k8s-ci-robot @karan