Default values in github event server options if they are nil to avoid panics #18210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
alvaroaleman
reviewed
Jul 8, 2020
droslean
force-pushed
the
eventserver-options
branch
from
74b66f0
to
a4d6d9a
Compare
droslean
changed the title
alvaroaleman
reviewed
Jul 8, 2020
Signed-off-by: Nikolaos Moraitis <nmoraiti@redhat.com>
droslean
force-pushed
the
eventserver-options
branch
from
a4d6d9a
to
3c9912d
Compare
alvaroaleman
approved these changes
Jul 8, 2020
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, droslean The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defaults the empty fields in the githubeventserver options to avoid panics when they are nil.
/cc @alvaroaleman @stevekuznetsov
Signed-off-by: Nikolaos Moraitis nmoraiti@redhat.com