Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kOps - Remove dependency on TravisCI #20136

Merged
merged 1 commit into from
Dec 7, 2020
Merged

kOps - Remove dependency on TravisCI #20136

merged 1 commit into from
Dec 7, 2020

Conversation

hakman
Copy link
Member

@hakman hakman commented Dec 4, 2020

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Dec 4, 2020
@hakman
Copy link
Member Author

hakman commented Dec 4, 2020

/assign @spiffxp

@hakman
Copy link
Member Author

hakman commented Dec 4, 2020

/retest

mikesplain
mikesplain reviewed Dec 4, 2020
View reviewed changes
Copy link
Contributor

@mikesplain mikesplain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hakman!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2020
@justinsb
Copy link
Member

justinsb commented Dec 5, 2020

Thanks!

/approve
/lgtm

@justinsb
Copy link
Member

justinsb commented Dec 6, 2020

Hmmm... I guess I can't approve in this directory... @spiffxp can you help?

@dims
Copy link
Member

dims commented Dec 7, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, hakman, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2020
@k8s-ci-robot k8s-ci-robot merged commit 4a2c7cf into kubernetes:master Dec 7, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Dec 7, 2020
@k8s-ci-robot
Copy link
Contributor

@hakman: Updated the config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key config.yaml using file config/prow/config.yaml

In response to this:

xRef: kubernetes/kops#10366

/cc @justinsb @mikesplain @rifelpet

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hakman hakman deleted the remove-travis-ci branch December 7, 2020 04:11
@hakman
Copy link
Member Author

hakman commented Dec 7, 2020

Thanks everyone. kOps is now TravisCI free :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikesplain mikesplain mikesplain left review comments

@justinsb justinsb Awaiting requested review from justinsb

@rifelpet rifelpet Awaiting requested review from rifelpet

Assignees

@spiffxp spiffxp

@justinsb justinsb

@mikesplain mikesplain

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@hakman @justinsb @dims @k8s-ci-robot @mikesplain @spiffxp