-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add SuspendJob to presubmit and periodic alpha jobs #20833
Conversation
Signed-off-by: Adhityaa Chandrasekar <adtac@google.com>
/hold cancel since we don't need to wait for the implementation PR to merge. In fact, merging this before that PR will tell us if the alpha e2e test passes presubmit. |
Wouldn't the binary fail to start if the feature is not recognized because it hasn't been merged yet? |
No, this change simply adds "[Feature:SuspendJob]" to the regex filter for tests. The feature gate is implicitly enabled by the AllAlpha=True which will include the implementation PR's new feature gate when it merges. |
gotcha /lgtm |
/assign @justaugustus |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adtac, justaugustus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
@adtac: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
See KEP: kubernetes/enhancements#2234
This PR enables the Feature:SuspendJob e2e tests added in kubernetes/kubernetes#98727 which adds an alpha feature gate.
/sig apps
/hold until kubernetes/kubernetes#98727 is merged
/cc @ahg-g @alculquicondor