Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SuspendJob to presubmit and periodic alpha jobs #20833

Merged
merged 1 commit into from
Feb 19, 2021

Conversation

adtac
Copy link
Member

@adtac adtac commented Feb 11, 2021

See KEP: kubernetes/enhancements#2234

This PR enables the Feature:SuspendJob e2e tests added in kubernetes/kubernetes#98727 which adds an alpha feature gate.

/sig apps
/hold until kubernetes/kubernetes#98727 is merged
/cc @ahg-g @alculquicondor

Signed-off-by: Adhityaa Chandrasekar <adtac@google.com>
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/apps Categorizes an issue or PR as relevant to SIG Apps. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 11, 2021
@adtac
Copy link
Member Author

adtac commented Feb 11, 2021

/hold cancel

since we don't need to wait for the implementation PR to merge. In fact, merging this before that PR will tell us if the alpha e2e test passes presubmit.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 11, 2021
@alculquicondor
Copy link
Member

Wouldn't the binary fail to start if the feature is not recognized because it hasn't been merged yet?

@adtac
Copy link
Member Author

adtac commented Feb 11, 2021

No, this change simply adds "[Feature:SuspendJob]" to the regex filter for tests. The feature gate is implicitly enabled by the AllAlpha=True which will include the implementation PR's new feature gate when it merges.

@alculquicondor
Copy link
Member

gotcha

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 11, 2021
@ahg-g
Copy link
Member

ahg-g commented Feb 17, 2021

/assign @justaugustus

@justaugustus
Copy link
Member

/lgtm
/approve
/hold (remove when ready; may cause merge conflict w/ #20890)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 19, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adtac, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2021
@adtac
Copy link
Member Author

adtac commented Feb 19, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 19, 2021
@k8s-ci-robot k8s-ci-robot merged commit ab73045 into kubernetes:master Feb 19, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 19, 2021
@k8s-ci-robot
Copy link
Contributor

@adtac: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key gcp-gce.yaml using file config/jobs/kubernetes/sig-cloud-provider/gcp/gcp-gce.yaml

In response to this:

See KEP: kubernetes/enhancements#2234

This PR enables the Feature:SuspendJob e2e tests added in kubernetes/kubernetes#98727 which adds an alpha feature gate.

/sig apps
/hold until kubernetes/kubernetes#98727 is merged
/cc @ahg-g @alculquicondor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants