Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sig-windows: disable test cases testing alpha features #21156

Merged
merged 1 commit into from
Mar 5, 2021

Conversation

chewong
Copy link
Member

@chewong chewong commented Mar 4, 2021

Signed-off-by: Ernest Wong chuwon@microsoft.com

  • Disabling [alpha] test cases for jobs running against the master branch.
  • Removing the following test cases:
    • [sig-scheduling] SchedulerPreemption for non-serial jobs since they are only available as serial test cases

/assign @jsturtevant

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 4, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chewong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2021
Signed-off-by: Ernest Wong <chuwon@microsoft.com>
@jsturtevant
Copy link
Contributor

jsturtevant commented Mar 4, 2021

if we skip alpha generically, I think we would end up skipping @marosset work on Windows HostProcess containers?

@@ -212,7 +212,7 @@ periodics:
- --aksengine-deploy-custom-k8s
- --aksengine-agentpoolcount=2
# Specific test args
- --test_args=--node-os-distro=windows --docker-config-file=$(DOCKER_CONFIG_FILE) --ginkgo.focus=\[Conformance\]|\[NodeConformance\]|\[sig-windows\]|\[sig-apps\].CronJob|\[sig-api-machinery\].ResourceQuota|\[sig-scheduling\].SchedulerPreemption|\[sig-autoscaling\].\[Feature:HPA\] --ginkgo.skip=\[LinuxOnly\]|\[Serial\]|GMSA|Guestbook.application.should.create.and.stop.a.working.application
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we droping HPA tests here? or those only run in serial/slow?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like most of the Feature:HPA test cases are serial / slow except for Kubernetes e2e suite.[sig-autoscaling] [Feature:HPA] Horizontal pod autoscaling (scale resource: CPU) [sig-autoscaling] ReplicationController light Should scale from 1 pod to 2 pods. Do we also want to enable that in non-serial jobs?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't look like we run it now. Just double checking that we didn't drop any tests.

@jsturtevant
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2021
@jsturtevant
Copy link
Contributor

We can address the hostprocess test once we know what is going to look like

@k8s-ci-robot k8s-ci-robot merged commit 64cede6 into kubernetes:master Mar 5, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 5, 2021
@k8s-ci-robot
Copy link
Contributor

@chewong: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key release-1.18-windows.yaml using file config/jobs/kubernetes-sigs/sig-windows/release-1.18-windows.yaml
  • key release-1.19-windows.yaml using file config/jobs/kubernetes-sigs/sig-windows/release-1.19-windows.yaml
  • key release-1.20-windows.yaml using file config/jobs/kubernetes-sigs/sig-windows/release-1.20-windows.yaml
  • key sig-windows-config.yaml using file config/jobs/kubernetes-sigs/sig-windows/sig-windows-config.yaml
  • key sig-windows-sac.yaml using file config/jobs/kubernetes-sigs/sig-windows/sig-windows-sac.yaml

In response to this:

Signed-off-by: Ernest Wong chuwon@microsoft.com

  • Disabling [alpha] test cases for jobs running against the master branch.
  • Removing the following test cases:
  • [sig-scheduling] SchedulerPreemption for non-serial jobs since they are only available as serial test cases

/assign @jsturtevant

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chewong chewong deleted the disable-alpha-features branch March 5, 2021 18:16
ionutbalutoiu added a commit to ionutbalutoiu/k8s-e2e-runner that referenced this pull request Apr 4, 2021
This is a follow-up PR to the upstream change:
kubernetes/test-infra#21156

Also, disabled `[Slow]` tests as they are meant to be executed
with `[Serial]` tests (which were disabled already).
ionutbalutoiu added a commit to ionutbalutoiu/k8s-e2e-runner that referenced this pull request Apr 4, 2021
This is a follow-up PR to the upstream change from:
kubernetes/test-infra#21156

Also, disabled `[Slow]` tests as they are meant to be executed
with `[Serial]` tests (which were disabled already).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants