-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sig-windows: disable test cases testing alpha features #21156
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chewong The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c5dd606
to
4ac1875
Compare
Signed-off-by: Ernest Wong <chuwon@microsoft.com>
4ac1875
to
d6ab96c
Compare
if we skip alpha generically, I think we would end up skipping @marosset work on Windows HostProcess containers? |
@@ -212,7 +212,7 @@ periodics: | |||
- --aksengine-deploy-custom-k8s | |||
- --aksengine-agentpoolcount=2 | |||
# Specific test args | |||
- --test_args=--node-os-distro=windows --docker-config-file=$(DOCKER_CONFIG_FILE) --ginkgo.focus=\[Conformance\]|\[NodeConformance\]|\[sig-windows\]|\[sig-apps\].CronJob|\[sig-api-machinery\].ResourceQuota|\[sig-scheduling\].SchedulerPreemption|\[sig-autoscaling\].\[Feature:HPA\] --ginkgo.skip=\[LinuxOnly\]|\[Serial\]|GMSA|Guestbook.application.should.create.and.stop.a.working.application |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we droping HPA tests here? or those only run in serial/slow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like most of the Feature:HPA
test cases are serial / slow except for Kubernetes e2e suite.[sig-autoscaling] [Feature:HPA] Horizontal pod autoscaling (scale resource: CPU) [sig-autoscaling] ReplicationController light Should scale from 1 pod to 2 pods
. Do we also want to enable that in non-serial jobs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't look like we run it now. Just double checking that we didn't drop any tests.
/lgtm |
We can address the hostprocess test once we know what is going to look like |
@chewong: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is a follow-up PR to the upstream change: kubernetes/test-infra#21156 Also, disabled `[Slow]` tests as they are meant to be executed with `[Serial]` tests (which were disabled already).
This is a follow-up PR to the upstream change from: kubernetes/test-infra#21156 Also, disabled `[Slow]` tests as they are meant to be executed with `[Serial]` tests (which were disabled already).
Signed-off-by: Ernest Wong chuwon@microsoft.com
[alpha]
test cases for jobs running against the master branch.[sig-scheduling] SchedulerPreemption
for non-serial jobs since they are only available as serial test cases/assign @jsturtevant