Prow Config: Do not deduplicate tide queries for different tenants
#28528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
size/M
smg247
changed the title
Config: Do not deduplicate tide queries for different tenantsProw Config: Do not deduplicate tide queries for different tenants
petr-muller
reviewed
Jan 27, 2023
|
/label tide/merge-method-squash |
k8s-ci-robot
added
the
tide/merge-method-squash
petr-muller
approved these changes
Jan 27, 2023
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: petr-muller, smg247 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second half of the solution to #28459. The first half involved not filtering out exposed repos that shared tide queries with hidden repos in #28460.
This fixes the same issue when the repos that share the same query have a different default tenant configured. I opted to approach this one by simply not deduplicating those queries so that the
tidequeries would be separated by tenant. This solves the problem without having to tinker with the filtering logic.An argument could be made that this bug would be better fixed by changing the filtering logic in
deck(similarly to how it was done in #28460), but with the way the default tenant ids are configured that would be a very clunky and involved change. I also think that the approach I have made will be more performant as it is only run each time the config is loaded rather than every time someone hits the 'PR Status' page. The downside of this approach is that there will be additionaltidequeries for the different tenant ids, if configured. This won't result in any issues, but is technically unnecessary outside of fixing this issue.