Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate blockade plugin for the k8s.io repo #29069

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

upodroid
Copy link
Member

I forgot to activate the plugin in #29052

/cc @BenTheElder @dims

Will this work on existing PRs or just new PRs?

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 16, 2023
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 16, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2023
@BenTheElder
Copy link
Member

Will this work on existing PRs or just new PRs?

It should work on pushes, it will not crawl previous changes though.

@BenTheElder
Copy link
Member

specifically these types of events incoming:

if pre.Action != github.PullRequestActionSynchronize &&
pre.Action != github.PullRequestActionOpened &&
pre.Action != github.PullRequestActionReopened {
return nil
}

@BenTheElder
Copy link
Member

/skip

@BenTheElder
Copy link
Member

hmm /skip doesn't work while running perhaps?
/override pull-test-infra-integration
(optional presubmit, not that relevant here, slowest presubmit, we want to get this blockade in place ASAP)

@k8s-ci-robot
Copy link
Contributor

@BenTheElder: Overrode contexts on behalf of BenTheElder: pull-test-infra-integration

In response to this:

hmm /skip doesn't work while running perhaps?
/override pull-test-infra-integration
(optional presubmit, not that relevant here, slowest presubmit, we want to get this blockade in place ASAP)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit 31cc998 into kubernetes:master Mar 16, 2023
@k8s-ci-robot
Copy link
Contributor

@upodroid: Updated the plugins configmap in namespace default at cluster test-infra-trusted using the following files:

  • key plugins.yaml using file config/prow/plugins.yaml

In response to this:

I forgot to activate the plugin in #29052

/cc @BenTheElder @dims

Will this work on existing PRs or just new PRs?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BenTheElder
Copy link
Member

only 25 PRs open in k8s.io currently, we can take a quick pass

@BenTheElder
Copy link
Member

commenting doesn't trigger it, close / reopen looks like it would

@BenTheElder
Copy link
Member

BenTheElder commented Mar 16, 2023

forced the handful of existing open PRs with label:area/k8s.gcr.io to be blockaded by close + reopen with a note.

none remaining without the blockade:
https://github.com/kubernetes/k8s.io/pulls?q=is%3Apr+is%3Aopen+-label%3Ado-not-merge%2Fblocked-paths+label%3Aarea%2Fk8s.gcr.io

@BenTheElder
Copy link
Member

BenTheElder commented Mar 16, 2023

@BenTheElder
Copy link
Member

there are other PRs that somehow don't have the label:area/k8s.gcr.io?

kubernetes/k8s.io#4948

@BenTheElder
Copy link
Member

I think 4948 was the only PR that touched k8s.gcr.io/ but didn't have the area label.

remaining PRs look fine https://github.com/kubernetes/k8s.io/pulls?q=is%3Apr+is%3Aopen+-label%3Ado-not-merge%2Fblocked-paths+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants