-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activate blockade
plugin for the k8s.io repo
#29069
Activate blockade
plugin for the k8s.io repo
#29069
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, upodroid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It should work on pushes, it will not crawl previous changes though. |
specifically these types of events incoming: test-infra/prow/plugins/blockade/blockade.go Lines 150 to 154 in e58df62
|
/skip |
hmm /skip doesn't work while running perhaps? |
@BenTheElder: Overrode contexts on behalf of BenTheElder: pull-test-infra-integration In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@upodroid: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
only 25 PRs open in k8s.io currently, we can take a quick pass |
commenting doesn't trigger it, close / reopen looks like it would |
forced the handful of existing open PRs with none remaining without the blockade: |
affected PRs: https://github.com/kubernetes/k8s.io/pulls?q=is%3Apr+label%3Ado-not-merge%2Fblocked-paths+is%3Aopen there are only 8 |
there are other PRs that somehow don't have the label:area/k8s.gcr.io? |
I think 4948 was the only PR that touched k8s.gcr.io/ but didn't have the area label. remaining PRs look fine https://github.com/kubernetes/k8s.io/pulls?q=is%3Apr+is%3Aopen+-label%3Ado-not-merge%2Fblocked-paths+ |
I forgot to activate the plugin in #29052
/cc @BenTheElder @dims
Will this work on existing PRs or just new PRs?