Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kube-state-metrics: Add rexagod as an approver #4957

Merged
merged 1 commit into from Mar 27, 2023
Merged

kube-state-metrics: Add rexagod as an approver #4957

merged 1 commit into from Mar 27, 2023

Conversation

mrueg
Copy link
Member

@mrueg mrueg commented Mar 16, 2023

@rexagod as an approver here as well.

@dgrisonnet @fpetkovski FYI

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 16, 2023
@k8s-ci-robot k8s-ci-robot added area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/k8s.gcr.io Code in k8s.gcr.io/ approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Mar 16, 2023
@BenTheElder
Copy link
Member

Hey, you'll have to move this to registry.k8s.io/, sorry we're working on kubernetes/enhancements#3720 ref #4934 kubernetes/test-infra#29069

@BenTheElder
Copy link
Member

[forcing bot to process this, will reopen immediately]
/close

@k8s-ci-robot
Copy link
Contributor

@BenTheElder: Closed this PR.

In response to this:

[forcing bot to process this, will reopen immediately]
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BenTheElder
Copy link
Member

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Mar 16, 2023
@k8s-ci-robot
Copy link
Contributor

@BenTheElder: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. label Mar 16, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 17, 2023 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: kgolab / name: Karol Gołąb (652fd6f)
  • ✅ login: jbartosik / name: Joachim (de9e9ea)
  • ✅ login: mrueg / name: Manuel Rüger (5a14f68)

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. area/registry.k8s.io Code in registry.k8s.io/ and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 17, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 17, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. label Mar 17, 2023
@k8s-ci-robot k8s-ci-robot added area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/dns DNS records for k8s.io, kubernetes.io, k8s.dev, etc., code in dns/ area/groups Google Groups management, code in groups/ area/provider/azure Issues or PRs related to azure provider area/provider/gcp Issues or PRs related to gcp provider area/release-eng Issues or PRs related to the Release Engineering subproject sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 17, 2023
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 17, 2023 •
edited

@mrueg: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-k8sio-dns-validate-config a409050 link true /test pull-k8sio-dns-validate-config
pull-k8sio-groups-test a409050 link true /test pull-k8sio-groups-test
pull-k8sio-cip a409050 link true /test pull-k8sio-cip

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mrueg
kube-state-metrics: Add rexagod as an approver
40d6071 
Signed-off-by: Manuel Rüger <manuel@rueg.eu>
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 17, 2023
@dgrisonnet
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 27, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, mrueg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit eb12f6d into kubernetes:main Mar 27, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgrisonnet dgrisonnet Awaiting requested review from dgrisonnet

@fpetkovski fpetkovski Awaiting requested review from fpetkovski

Assignees

@dgrisonnet dgrisonnet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/dns DNS records for k8s.io, kubernetes.io, k8s.dev, etc., code in dns/ area/groups Google Groups management, code in groups/ area/k8s.gcr.io Code in k8s.gcr.io/ area/provider/azure Issues or PRs related to azure provider area/provider/gcp Issues or PRs related to gcp provider area/registry.k8s.io Code in registry.k8s.io/ area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
[sig-windows] PR tracking
Status: Done
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mrueg @BenTheElder @k8s-ci-robot @dgrisonnet