Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kOps: Make kuberouter presubmit optional #29332

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

hakman
Copy link
Member

@hakman hakman commented Apr 19, 2023

I think this is a better option than reverting to 1.26 for testing.

Ref: kubernetes/kops#15319 kubernetes/kops#15322

/cc @olemarkus @rifelpet

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config area/jobs approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 19, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 19, 2023
@k8s-ci-robot k8s-ci-robot merged commit 2528f6d into kubernetes:master Apr 19, 2023
@hakman hakman deleted the kuberouter-optional branch April 19, 2023 09:10
@k8s-ci-robot
Copy link
Contributor

@hakman: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key kops-presubmits-network-plugins.yaml using file config/jobs/kubernetes/kops/kops-presubmits-network-plugins.yaml

In response to this:

I think this is a better option than reverting to 1.26 for testing.

Ref: kubernetes/kops#15319 kubernetes/kops#15322

/cc @olemarkus @rifelpet

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rifelpet
Copy link
Member

rifelpet commented May 2, 2023

@hakman can we revert this now?

@hakman
Copy link
Member Author

hakman commented May 2, 2023

@rifelpet No, this is still failing. Maybe the AWS VPC CNI one.

@olemarkus
Copy link
Member

AWS VPC is marked as stable, while kube-router is ... questionable. So second enabling this for the former and permanently skipping the latter.

@hakman
Copy link
Member Author

hakman commented May 2, 2023

Seems that we had someone wanting to continue work on kube-router. Not sure if still the case.
kubernetes/kops#15270 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants