-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kOps: Make kuberouter presubmit optional #29332
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman, olemarkus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@hakman: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@hakman can we revert this now? |
@rifelpet No, this is still failing. Maybe the AWS VPC CNI one. |
AWS VPC is marked as stable, while kube-router is ... questionable. So second enabling this for the former and permanently skipping the latter. |
Seems that we had someone wanting to continue work on kube-router. Not sure if still the case. |
I think this is a better option than reverting to 1.26 for testing.
Ref: kubernetes/kops#15319 kubernetes/kops#15322
/cc @olemarkus @rifelpet