-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update containerd to v1.6.20 #15319
Update containerd to v1.6.20 #15319
Conversation
anthonyhaussman
commented
Apr 15, 2023
- https://github.com/containerd/containerd/releases/tag/v1.6.19
- https://github.com/containerd/containerd/releases/tag/v1.6.20
Hi @anthonyhaussman. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@anthonyhaussman This looks good. Could you split the Go part into a separate commit, like in https://github.com/kubernetes/kops/pull/15159/commits? It would make it easier to cherry-pick. |
086ab23
to
a28b11f
Compare
It's done @hakman 🙂 |
Thanks @anthonyhaussman! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
1 similar comment
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
/hold the e2e jobs are failing until the credential provider is fixed and released in cloud-provider-aws |
It's been released, but kOps needs to start supporting downloading and using it. The credentials provider is also not really tested upstream, so there may be more work needed there as well. Currently working on what's needed kOps-side and will then add e2e in the aws cloud provider. |
@rifelpet @olemarkus Should we maybe make these 2 tests optional for now? |
How about reverting the deps update? That way the head of master is not broken |
The problem is that the functionality for pulling ECR-containers are removed from kubelet. So we'd have to run these tests with K8s 1.26 instead. Which I am not necessarily against. If the ECR credentials provider is also broken, we won't get the PR to start using it into the repo either. |
If we know k8s 1.27 doesn't work with kops yet then temporarily pinning our presubmit tests to k8s 1.26 seems reasonable |
/test all |
@anthonyhaussman: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test pull-kops-e2e-cni-flannel |
/hold cancel |