Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure: Add CCM ref for presubmit k/k jobs #29359

Merged
merged 1 commit into from Apr 25, 2023
Merged

Azure: Add CCM ref for presubmit k/k jobs #29359

merged 1 commit into from Apr 25, 2023

Conversation

CecileRobertMichon
Copy link
Member

In preparation for kubernetes/kubernetes#117503 and kubernetes-sigs/cluster-api-provider-azure#3456, this PR adds extra_refs for all k/k Azure presubmit jobs so we can build cloud-provider-azure when testing k8s + out of tree cloud-provider.

This won't break existing jobs (the extra_ref just won't be used until the PRs mentioned above are merged).

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 24, 2023
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 24, 2023
CecileRobertMichon
CecileRobertMichon commented Apr 24, 2023
View reviewed changes
config/jobs/kubernetes/sig-cloud-provider/azure/release-master.yaml
preset-azure-cred-only: "true"
preset-azure-anonymous-pull: "true"
extra_refs:
- org: jackfrancis #TODO change back to kubernetes-sigs
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jackfrancis removed because this branch is outdated and the job hasn't run since last year. It won't work with out of tree cloud-provider as-is.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@CecileRobertMichon CecileRobertMichon mentioned this pull request Apr 24, 2023
Merged
@CecileRobertMichon
Copy link
Member Author

/assign @dims @andyzhangx @jackfrancis

@dims
Copy link
Member

dims commented Apr 24, 2023

/approve
/lgtm

/hold please remove hold when ready @CecileRobertMichon !

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Apr 24, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis
Copy link
Contributor

/lgtm

@CecileRobertMichon
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2023
@k8s-ci-robot k8s-ci-robot merged commit 7864f54 into kubernetes:master Apr 25, 2023
6 checks passed
@k8s-ci-robot
Copy link
Contributor

@CecileRobertMichon: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key release-1.24.yaml using file config/jobs/kubernetes/sig-cloud-provider/azure/release-1.24.yaml
  • key release-1.25.yaml using file config/jobs/kubernetes/sig-cloud-provider/azure/release-1.25.yaml
  • key release-1.26.yaml using file config/jobs/kubernetes/sig-cloud-provider/azure/release-1.26.yaml
  • key release-1.27.yaml using file config/jobs/kubernetes/sig-cloud-provider/azure/release-1.27.yaml
  • key release-master.yaml using file config/jobs/kubernetes/sig-cloud-provider/azure/release-master.yaml

In response to this:

In preparation for kubernetes/kubernetes#117503 and kubernetes-sigs/cluster-api-provider-azure#3456, this PR adds extra_refs for all k/k Azure presubmit jobs so we can build cloud-provider-azure when testing k8s + out of tree cloud-provider.

This won't break existing jobs (the extra_ref just won't be used until the PRs mentioned above are merged).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@elmiko elmiko mentioned this pull request Sep 29, 2023
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackfrancis jackfrancis jackfrancis left review comments

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@mboersma mboersma Awaiting requested review from mboersma

Assignees

@dims dims

@jackfrancis jackfrancis

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@CecileRobertMichon @dims @k8s-ci-robot @jackfrancis @andyzhangx