-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testgrid: Add blocking tests for next release #2967
testgrid: Add blocking tests for next release #2967
Conversation
This should maybe be compared with whatever is in #2965 |
testgrid/config/config.yaml
Outdated
dashboard_tab: | ||
# Build/Verify | ||
- name: build-master | ||
test_group_name: ci-kubernetes-build-master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the actual job does not have a -master
with it 👿
@@ -1933,6 +1933,92 @@ dashboards: | |||
- name: kubelet-non-cri-1.6 | |||
test_group_name: ci-kubernetes-node-kubelet-non-cri-1.6 | |||
|
|||
# Blocking tests for the next release | |||
- name: release-master-blocking |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
master-blocking?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to know what broken tests will be blocking the next release, long before we actually cut the branch for that release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My suggestion is to use a more pithy name than release-master-blocking.
Release-gating test suites are currently stored here. Whatever we do we should have a single source of truth. The following information cajn be tracked ahead of a release using
** Looking to expose this in a prettier (dashboard) way, externally. |
e5d4908
to
e2e4336
Compare
@caesarxuchao are you aware of those release-gating tests? |
@caesarxuchao Anyone who runs |
@apelisse I believe the answer is both? I know we want different tests gating different releases. They are mostly the same, but there are variations. Ideally this shold be captured in a checked in file that is easily consumable by scripts, tools, dashboards and easily updated by humans as needed. Maybe we need to move these to release-suites-1.6.txt, release-suites-1.7.txt, etc and keep them in a more central location on GCS or maybe a file on kubernetes/community or kubernetes/features as one-level up from kubernetes/test-infra and kubernetes/release. |
testgrid/config/config.yaml
Outdated
test_group_name: ci-kubernetes-federation-build | ||
# E2E | ||
- name: gce-master | ||
test_group_name: ci-kubernetes-e2e-gce-release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
simply ci-kubernetes-e2e-gce
, w/o -release
:-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, thank you for pointing that out. Many of these are broken, but I'm waiting for more consensus before spending time fixing them :)
@david-mcmahon As discussed offline, we will plan to create a test-grid page for converging on passing tests in 1.7, and follow up with an integration story for anago + testgrid workflow. |
e2e4336
to
5612cbf
Compare
Create a master blocking suite, so that we can know what blocking tests are broken before we even cut the branch. This will help the buildcop investigate tests that should not break.
5612cbf
to
0e57b72
Compare
/lgtm |
Create a master blocking suite, so that we can know what blocking tests
are broken before we even cut the branch. This will help the buildcop
investigate tests that should not break.
This is a copy-paste of release 1.6 blocking tests.
@pwittrock @dchen1107