Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testgrid: Add blocking tests for next release #2967

Merged
merged 1 commit into from
Jun 6, 2017

Conversation

apelisse
Copy link
Member

@apelisse apelisse commented Jun 5, 2017

Create a master blocking suite, so that we can know what blocking tests
are broken before we even cut the branch. This will help the buildcop
investigate tests that should not break.

This is a copy-paste of release 1.6 blocking tests.

@pwittrock @dchen1107

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 5, 2017
@apelisse
Copy link
Member Author

apelisse commented Jun 5, 2017

This should maybe be compared with whatever is in #2965

dashboard_tab:
# Build/Verify
- name: build-master
test_group_name: ci-kubernetes-build-master
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the actual job does not have a -master with it 👿

@@ -1933,6 +1933,92 @@ dashboards:
- name: kubelet-non-cri-1.6
test_group_name: ci-kubernetes-node-kubelet-non-cri-1.6

# Blocking tests for the next release
- name: release-master-blocking
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

master-blocking?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to know what broken tests will be blocking the next release, long before we actually cut the branch for that release.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My suggestion is to use a more pithy name than release-master-blocking.

@david-mcmahon
Copy link
Contributor

Release-gating test suites are currently stored here. Whatever we do we should have a single source of truth.

The following information cajn be tracked ahead of a release using relnotes**

  • Pending (live) release notes preview
  • Pending PRs waiting to be landed on the branch
  • State of testing on master or branch and GO/NO-GO signal

** relnotes --htmlize-md --branch=master --preview --markdown-file=/tmp/k8s-master.md --html-file=$HOME/www/k8s-master.html
or relnotes --htmlize-md --branch=release-1.6 --preview --markdown-file=/tmp/k8s-release-1.6.md --html-file=$HOME/www/k8s-release-1.6.html

Looking to expose this in a prettier (dashboard) way, externally.

@apelisse apelisse force-pushed the testgrid-add-master-blocking branch from e5d4908 to e2e4336 Compare June 5, 2017 21:57
@apelisse
Copy link
Member Author

apelisse commented Jun 5, 2017

Whatever we do we should have a single source of truth.

Yes,

But then what is the current source of truth, between your link, #2965 and #2029 ?

@krzyzacy
Copy link
Member

krzyzacy commented Jun 5, 2017

@caesarxuchao are you aware of those release-gating tests?

@david-mcmahon
Copy link
Contributor

@caesarxuchao Anyone who runs anago to release Kubernetes is aware of those release-gating tests. You can't cut a branch or release unless those are all green or you actively bypass it.

@david-mcmahon
Copy link
Contributor

@apelisse I believe the answer is both? I know we want different tests gating different releases. They are mostly the same, but there are variations. Ideally this shold be captured in a checked in file that is easily consumable by scripts, tools, dashboards and easily updated by humans as needed. Maybe we need to move these to release-suites-1.6.txt, release-suites-1.7.txt, etc and keep them in a more central location on GCS or maybe a file on kubernetes/community or kubernetes/features as one-level up from kubernetes/test-infra and kubernetes/release.

test_group_name: ci-kubernetes-federation-build
# E2E
- name: gce-master
test_group_name: ci-kubernetes-e2e-gce-release
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simply ci-kubernetes-e2e-gce, w/o -release :-)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, thank you for pointing that out. Many of these are broken, but I'm waiting for more consensus before spending time fixing them :)

@pwittrock
Copy link
Member

@david-mcmahon As discussed offline, we will plan to create a test-grid page for converging on passing tests in 1.7, and follow up with an integration story for anago + testgrid workflow.

@apelisse apelisse force-pushed the testgrid-add-master-blocking branch from e2e4336 to 5612cbf Compare June 6, 2017 20:21
Create a master blocking suite, so that we can know what blocking tests
are broken before we even cut the branch. This will help the buildcop
investigate tests that should not break.
@apelisse apelisse force-pushed the testgrid-add-master-blocking branch from 5612cbf to 0e57b72 Compare June 6, 2017 20:40
@krzyzacy
Copy link
Member

krzyzacy commented Jun 6, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2017
@apelisse apelisse merged commit df7b0c0 into kubernetes:master Jun 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants