Add crier RocketChat reporter #30135

robinschneider · 2023-07-19T18:48:55Z

Add crier reporter for RocketChat.
Reporter is based on the Slack reporter.
It uses a RocketChat Webhook.

Docs will be contributed to the Documentation repository.

k8s-ci-robot · 2023-07-19T18:49:03Z

Welcome @robinschneider!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2023-07-19T18:49:04Z

Hi @robinschneider. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

petr-muller · 2023-07-20T16:17:43Z

/cc
/test all

petr-muller · 2023-07-20T16:27:31Z

Thanks! I'm not sure how much I'll be able to look at this immediately but I'll try to not let it rot ;)

* Fix lint issues * Fix prow-config-documented.yaml

robinschneider · 2023-07-20T19:07:47Z

/retest

k8s-ci-robot · 2023-07-20T19:08:02Z

@robinschneider: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

robinschneider · 2023-07-20T19:18:39Z

@petr-muller Thank you! I fixed the lint issues.

Priyankasaggu11929 · 2023-07-21T05:01:10Z

/ok-to-test

petr-muller

I'm not a great fan of essentially duplicating this much code, but let's defer asking for some kind of WebhookReporter abstraction to anyone who tries to add a third copy ;)

Some comments inline.

prow/plugins/plugins.go

prow/cmd/hook/main.go

prow/config/config.go

prow/rocketchat/client.go

* Improve rocketchat reporter * Reduce code duplication * Moved test to clientutil

robinschneider · 2023-07-27T14:11:21Z

@petr-muller Thank you again for your feedback.
I went over all the points you addressed.

robinschneider · 2023-08-05T11:48:25Z

@petr-muller I wanted to check in and see if you've had a chance to review the recent changes I made. Your insights and feedback would be greatly appreciated. Please let me know if you have any thoughts or suggestions.

petr-muller · 2023-08-07T18:54:03Z

Sorry, I switch between "vacation" and "catching up with accumulated backlog" modes in summer :)

I hope to get to k/test-infra reviews this week again.

petr-muller

Thank you!

petr-muller · 2023-08-10T13:35:36Z

oh right, this changes the CRD
/assign @michelle192837 @listx

listx

I don't have a lot of time to review OSS PRs, unfortunately, so I didn't read the entire PR. However (1) I am not opposed to this (we're just adding a new reporter type), and (2) it seems like Petr already reviewed some things, so I think that's good enough. I just have some minor questions, thanks.

listx · 2023-08-11T23:30:27Z

prow/cmd/hook/main.go

+
+	// This is necessary since RocketChat is optional.
+	if o.rocketChatChannel != "" {
+		tokens = append(tokens, o.rocketChatChannel)


I'm not super familiar with Crier, but what stops us from adopting o.rocketChat.Channel, similar to o.bugzilla.ApiKeyPath? I.e., we should probably group the rocketChat-related things into o.rocketChat, no?

I am not familiar with the bugzilla reporter, but my implementation is a copy of the slack reporter that does it the same way. Hope this is fine.

prow/config/config.go

k8s-ci-robot · 2023-09-04T21:29:41Z

New changes are detected. LGTM label has been removed.

k8s-ci-robot · 2023-09-04T21:29:55Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: petr-muller, robinschneider
Once this PR has been reviewed and has the lgtm label, please ask for approval from listx. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

config/prow/cluster/OWNERS
~~prow/OWNERS~~ [petr-muller]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2023-12-07T07:39:32Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-triage-robot · 2024-03-06T07:57:52Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-ci-robot · 2024-04-09T23:04:44Z

@robinschneider: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-test-infra-unit-test	`451007e`	link	true	`/test pull-test-infra-unit-test`
pull-test-infra-unit-test-race-detector-nonblocking	`451007e`	link	false	`/test pull-test-infra-unit-test-race-detector-nonblocking`
pull-test-infra-misc-image-build-test	`451007e`	link	true	`/test pull-test-infra-misc-image-build-test`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jihoon-seo · 2024-04-16T09:29:01Z

Hello @robinschneider, the Prow source code has been moved to https://github.com/kubernetes-sigs/prow on April 9, 2024.
Please consider migrate this PR (by opening a new one in there).
Thanks!

robinschneider and others added 2 commits July 19, 2023 20:36

Add crier rocketchat reporter

17efb42

Fix slack URL

2d4a5e9

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 19, 2023

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 19, 2023

k8s-ci-robot requested review from cblecker, cjwagner, droslean, MadhavJivrajani, nikhita and Priyankasaggu11929 July 19, 2023 18:49

k8s-ci-robot requested a review from petr-muller July 20, 2023 16:17

robinschneider added 2 commits July 20, 2023 20:05

Fix lint issues (#3)

6233d4c

Fix lint & config (#4)

53d6f4e

* Fix lint issues * Fix prow-config-documented.yaml

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 21, 2023

k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 21, 2023

petr-muller reviewed Jul 21, 2023

View reviewed changes

robinschneider added 2 commits July 25, 2023 23:49

Improve rocketchat reporter (#5)

fd68184

Improve rocketchat (#6)

34da8ed

* Improve rocketchat reporter * Reduce code duplication * Moved test to clientutil

petr-muller approved these changes Aug 10, 2023

View reviewed changes

k8s-ci-robot assigned petr-muller Aug 10, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 10, 2023

k8s-ci-robot assigned listx and michelle192837 Aug 10, 2023

listx reviewed Aug 11, 2023

View reviewed changes

remove duplicate RocketChatReporterConfigs (#7)

451007e

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 4, 2023

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 7, 2023

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add crier RocketChat reporter #30135

Add crier RocketChat reporter #30135

robinschneider commented Jul 19, 2023

k8s-ci-robot commented Jul 19, 2023

k8s-ci-robot commented Jul 19, 2023

petr-muller commented Jul 20, 2023

petr-muller commented Jul 20, 2023

robinschneider commented Jul 20, 2023

k8s-ci-robot commented Jul 20, 2023

robinschneider commented Jul 20, 2023

Priyankasaggu11929 commented Jul 21, 2023

petr-muller left a comment

robinschneider commented Jul 27, 2023

robinschneider commented Aug 5, 2023

petr-muller commented Aug 7, 2023

petr-muller left a comment

petr-muller commented Aug 10, 2023

listx left a comment

listx Aug 11, 2023

robinschneider Sep 4, 2023

k8s-ci-robot commented Sep 4, 2023

k8s-ci-robot commented Sep 4, 2023

k8s-ci-robot commented Dec 7, 2023

k8s-triage-robot commented Mar 6, 2024

k8s-ci-robot commented Apr 9, 2024

jihoon-seo commented Apr 16, 2024

Add crier RocketChat reporter #30135

Are you sure you want to change the base?

Add crier RocketChat reporter #30135

Conversation

robinschneider commented Jul 19, 2023

k8s-ci-robot commented Jul 19, 2023

k8s-ci-robot commented Jul 19, 2023

petr-muller commented Jul 20, 2023

petr-muller commented Jul 20, 2023

robinschneider commented Jul 20, 2023

k8s-ci-robot commented Jul 20, 2023

robinschneider commented Jul 20, 2023

Priyankasaggu11929 commented Jul 21, 2023

petr-muller left a comment

Choose a reason for hiding this comment

robinschneider commented Jul 27, 2023

robinschneider commented Aug 5, 2023

petr-muller commented Aug 7, 2023

petr-muller left a comment

Choose a reason for hiding this comment

petr-muller commented Aug 10, 2023

listx left a comment

Choose a reason for hiding this comment

listx Aug 11, 2023

Choose a reason for hiding this comment

robinschneider Sep 4, 2023

Choose a reason for hiding this comment

k8s-ci-robot commented Sep 4, 2023

k8s-ci-robot commented Sep 4, 2023

k8s-ci-robot commented Dec 7, 2023

k8s-triage-robot commented Mar 6, 2024

k8s-ci-robot commented Apr 9, 2024

jihoon-seo commented Apr 16, 2024