-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new focus on [Feature:VolumeAttributesClass] #31844
Conversation
…etes-e2e-gce-cos-alpha-features job
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: carlory The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
My understanding of "generic" is "does not depend on and does not test specific features". That doesn't seem to be how you are using the term here because you are adding a test for one particular feature. You probably meant "this job is run as a service for all of k/k" (right?) - but how do you know? There's no comment on the job describing it like that, so I can't verify that statement. 🤔 Given that lack of additional information, the way I read the diff, SIG Storage is asking SIG Cloud Provider to run and monitor tests for a feature that is owned by SIG Storage. You'll need approval from SIG Cloud Provider. With my "SIG Testing" hat on I don't care as long as someone takes care of the job and the feature. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/close |
@carlory: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There's no job which can be used to run e2e tests for the VolumeAttributes feature. This PR add new focus on [Feature:VolumeAttributesClass] into the existing job
pull-kubernetes-e2e-gce-cos-alpha-features
which is a generic alpha job for all k/k.Ref #31717
Ref #31666
/cc @msau42 @pohly @aojea @sunnylovestiramisu