Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new focus on [Feature:VolumeAttributesClass] #31844

Closed
wants to merge 1 commit into from

Conversation

carlory
Copy link
Member

@carlory carlory commented Feb 6, 2024

There's no job which can be used to run e2e tests for the VolumeAttributes feature. This PR add new focus on [Feature:VolumeAttributesClass] into the existing job pull-kubernetes-e2e-gce-cos-alpha-features which is a generic alpha job for all k/k.

Ref #31717
Ref #31666

/cc @msau42 @pohly @aojea @sunnylovestiramisu

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 6, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: carlory
Once this PR has been reviewed and has the lgtm label, please assign cheftako for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 6, 2024
@pohly
Copy link
Contributor

pohly commented Feb 6, 2024

the existing job pull-kubernetes-e2e-gce-cos-alpha-features which is a generic alpha job for all k/k.

My understanding of "generic" is "does not depend on and does not test specific features". That doesn't seem to be how you are using the term here because you are adding a test for one particular feature. You probably meant "this job is run as a service for all of k/k" (right?) - but how do you know? There's no comment on the job describing it like that, so I can't verify that statement. 🤔

Given that lack of additional information, the way I read the diff, SIG Storage is asking SIG Cloud Provider to run and monitor tests for a feature that is owned by SIG Storage. You'll need approval from SIG Cloud Provider. With my "SIG Testing" hat on I don't care as long as someone takes care of the job and the feature.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 21, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@carlory
Copy link
Member Author

carlory commented Feb 23, 2024

/close
See #31717 (comment)

@k8s-ci-robot
Copy link
Contributor

@carlory: Closed this PR.

In response to this:

/close
See #31717 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants