add a dedicated job for testing vac feature #31717
Conversation
k8s-ci-robot
requested review from
msau42,
pohly,
sunnylovestiramisu and
xing-yang
k8s-ci-robot
added
cncf-cla: yes
carlory
force-pushed
the
add-dedicated-job-for-vac-feature
branch
3 times, most recently
from
4625d59
to
68df848
Compare
k8s-ci-robot
added
size/M
carlory
force-pushed
the
add-dedicated-job-for-vac-feature
branch
from
68df848
to
394d2ec
Compare
| @@ -54,6 +54,54 @@ presubmits: | |||
| cpu: "2" | |||
| memory: "6Gi" | |||
|
|
|||
| # This jobs runs e2e.test with a focus on tests for the VolumeAttributesClass feature (currently alpha) | |||
| # on a kind cluster | |||
| - name: pull-kubernetes-e2e-storage-kind-vac-feature | |||
There was a problem hiding this comment.
Does SIG Storage have other features that need a special cluster?
It might make more sense to have a pull-kubernetes-e2e-storage-kind-alpha-features job where SIG storage alpha feature gates + API groups are enabled and then all tests for those run. Because this is a job owned by the SIG, you know when to update this job during feature promotion.
There was a problem hiding this comment.
I don't know but I believe that the answer will be yes. Perhaps we need the feature owner to complete this section as well when they add e2e tests.
There was a problem hiding this comment.
even if the feature is promoted to beta, the cluster created by the alpha job still turns on the feature gate regardless of what the feature-gate stage is.
So I want to rename the job to pull-kubernetes-e2e-storage-kind-alpha-beta-features in order to void the confusion.
cc @pohly
There was a problem hiding this comment.
That name works for me.
We still have the confusion between "job that tests alpha/beta features" (this one here) vs. "job which tests GA features with alpha/beta features enabled" (the SIG Testing jobs), but I can't think of better names.
Co-authored-by: Patrick Ohly <patrick.ohly@intel.com>
carlory
force-pushed
the
add-dedicated-job-for-vac-feature
branch
from
fcb1467
to
e9853a7
Compare
| @@ -54,6 +54,52 @@ presubmits: | |||
| cpu: "2" | |||
| memory: "6Gi" | |||
|
|
|||
| # This jobs runs e2e.test with a focus on tests for all alpha storage features on a kind cluster | |||
| - name: pull-kubernetes-e2e-storage-kind-alpha-features | |||
There was a problem hiding this comment.
Does this mean even for a change without alpha feature change, it will still run to make sure the PR does not break our alpha changes?
There was a problem hiding this comment.
It need be triggered manually by PR author via /test pull-kubernetes-e2e-storage-kind-alpha-features command. I'm not sure whether it should be run automatically when PR is created or not. cc @pohly i.e.
always_run: true
optional: true
There's a periodic job ci-kubernetes-e2e-storage-kind-alpha-features that runs this test periodically.
Once the feature is GA, we can drop \[Feature:VolumeAttributesClass\] from the FOCUS env.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
added
the
do-not-merge/hold
|
Discussed with @msau42, we should move everything to kind, and not use sig-cloud-provider, the future of sig-cloud-provider is uncertain and each provider is not committed to make sure it is up to date. |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/cc @pohly |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: carlory, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@carlory: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There's no job which can be used to run e2e tests for the VolumeAttributes feature. This PR adds a dedicated job in the sig-storage directory.
e2e tests for vac:
Some discussion can be found in the #31666.
/cc @pohly @xing-yang @msau42 @sunnylovestiramisu