Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bind GCE/AWS credentials and run AWS e2e inside docker #66

Merged
merged 1 commit into from
Jun 29, 2016
Merged

Bind GCE/AWS credentials and run AWS e2e inside docker #66

merged 1 commit into from
Jun 29, 2016

Conversation

ixdy
Copy link
Member

@ixdy ixdy commented May 21, 2016

Trying #19 again.

kubernetes/kubernetes/pull/25376 fixed the issues we encountered the first time.

spxtr
spxtr reviewed May 21, 2016
View reviewed changes
jenkins/job-configs/kubernetes-jenkins/kubernetes-e2e.yaml
@@ -587,27 +588,23 @@
trigger-job: ''
timeout: 240
jenkins_node: 'master'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it still need to run on master?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch. that's one of the main reasons to do this change in the first place. :)

@ixdy
Copy link
Member Author

ixdy commented May 21, 2016

Seems to work: https://console.cloud.google.com/storage/browser/kubernetes-jenkins/logs/kubernetes-e2e-gce-dockerized-test/73

@ixdy
Copy link
Member Author

ixdy commented May 23, 2016

@fejta @spxtr should we try to merge this sometime today?

@spxtr
Copy link
Contributor

spxtr commented May 23, 2016

I'm fine with it, but @fejta is on call.

spxtr
spxtr reviewed May 23, 2016
View reviewed changes
jenkins/job-configs/kubernetes-jenkins/credentials.yaml
@@ -0,0 +1,19 @@
- wrapper:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might appreciate a comment explaining what these are.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about that, but I wasn't sure that a comment would be any more descriptive than the env var name itself.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, seems reasonable.

@fejta
Copy link
Contributor

fejta commented May 23, 2016

Before merging I want one of the following to be true:

  • This change passes on a staging jenkins instance
  • http://submit-queue.k8s.io/#/e2e has had 80% health for the past 24 hours
  • The mergebot merged at least 30 PRs in the past 24 hours
  • There are no 1.3 PRs in the queue

@spxtr
Copy link
Contributor

spxtr commented May 23, 2016

This change passes on a staging jenkins instance

It passed in a staging Jenkins job for GCE. I don't think that's enough confidence though, since it hits everything.

@ixdy
Copy link
Member Author

ixdy commented May 23, 2016

I understood what caused the breakage before, and it's been fixed, so I am reasonably confident this is a no-op for most builds. I'm not 100% sure though.

Also, it's not possible to merge 30 PRs in one day. The unit test build takes around 1 hour right now.

@ixdy
Copy link
Member Author

ixdy commented May 23, 2016

given that today is the last day for 1.3 features, it seems reasonable to hold off.

@ixdy ixdy mentioned this pull request May 27, 2016
Closed
@ixdy
Copy link
Member Author

ixdy commented Jun 29, 2016

alright, here goes...

@ixdy ixdy merged commit 667d536 into kubernetes:master Jun 29, 2016
@ixdy
Copy link
Member Author

ixdy commented Jun 29, 2016

well, this broke AWS - we secretly depended on the aws binary installed on the Jenkins master:

18:39:43 2016/06/28 18:39:43 e2e.go:212: Running: up
18:39:43 ... Starting cluster in us-west-2a using provider aws
18:39:43 ... calling verify-prereqs
18:39:43 Can't find aws in PATH, please fix and retry.
18:39:43 2016/06/28 18:39:43 e2e.go:218: Error running up: exit status 1

I'm not sure if we should add this to the kubekins-test image or if we should install it on each invocation (like we do with gcloud).

@spxtr
Copy link
Contributor

spxtr commented Jun 29, 2016

Both seem reasonable to me. Is it worth using a new image for these?

Similarly, is it worth using a different image for e2e testing and unit/integration testing?

@ixdy ixdy mentioned this pull request Jun 29, 2016
Merged
k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this pull request Jul 1, 2016
Merge pull request #28237 from ixdy/kubekins-aws
d8a54c7 
Automatic merge from submit-queue

Install pip in kubekins test image and install AWS cli when needed

Follow-on to kubernetes/test-infra#66. This fixes AWS hopefully.

I haven't pushed the image yet.

cc @fejta
simonswine pushed a commit to simonswine/test-infra that referenced this pull request Nov 16, 2017
@munnerz
Merge pull request kubernetes#66 from jetstack/fix-cherrypick
6328cba 
Use target-repo in cherrypick queue service label selector
mborsz pushed a commit to mborsz/test-infra that referenced this pull request Dec 14, 2018
@shyamjvs
Merge pull request kubernetes#66 from shyamjvs/benchmark-update
1b8c66d 
Benchmark marks metrics with too low avg values as matched & prints some more useful info
ostromart pushed a commit to ostromart/test-infra that referenced this pull request Jul 26, 2019
@sebastienvas
Adds convenience method for pull request. (kubernetes#66)
e7494a0 
* Adds convenience method for pull request.

* Reformat code

* Missing property
MushuEE pushed a commit to MushuEE/test-infra that referenced this pull request Mar 17, 2022
@timburks
Merge pull request kubernetes#66 from orsobruno/patch1
aead050 
Ignore generated extension files and IntelliJ IDEA project files
kyma-bot added a commit to kyma-bot/test-infra that referenced this pull request Mar 15, 2024
@kyma-bot
Merge pull request kubernetes#66 from kyma-bot/autobump
1590117 
Update testimages to v20240314-e80ad011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ixdy @spxtr @fejta @googlebot