-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable prepull for k8s 1.11+ containerd test. #8748
Enable prepull for k8s 1.11+ containerd test. #8748
Conversation
Signed-off-by: Lantao Liu <lantaol@google.com>
/approve |
@@ -92,6 +92,7 @@ | |||
"--check-leaked-resources", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should move all of this to another owned directory with you and yuju as OWNERS :-)
@Random-Liu ^^ do you want to do in this PR, or as a follow up? /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, krzyzacy, Random-Liu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@krzyzacy I'll do it in another PR. Will send out today. |
ack, feel free to /hold cancel this one |
/hold cancel |
kubernetes/kubernetes#55141 is fixed. We should be able to enable prepull now.
/cc @yujuhong
Signed-off-by: Lantao Liu lantaol@google.com