Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup branch-protection for kubernetes-client and kubernetes-incubator #9114

Merged
merged 2 commits into from Aug 27, 2018

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Aug 21, 2018

Every repo already should have cla/linuxfoundation as required, but there are
a number that don't. This fixes that.

Repos that have other required status contexts have those enabled as well

ref: #6227

/hold
for comment / lazy consensus, no objections by friday 10am PT and I'll merge this

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/prow Issues or PRs related to prow size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 21, 2018
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2018
@spiffxp spiffxp force-pushed the branch-protect-all-k8s-orgs branch from e79f764 to 8d28255 Compare August 21, 2018 17:16
@spiffxp spiffxp force-pushed the branch-protect-all-k8s-orgs branch from 8d28255 to aaa4ab3 Compare August 21, 2018 17:21
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 21, 2018
@spiffxp
Copy link
Member Author

spiffxp commented Aug 21, 2018

/sig contributor-experience

@k8s-ci-robot k8s-ci-robot added the sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. label Aug 21, 2018
@cblecker
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cblecker
Copy link
Member

Maybe kubernetes-csi too?

@spiffxp
Copy link
Member Author

spiffxp commented Aug 21, 2018

kubernetes-csi is already covered, they asked earlier

now I'm voluntolding

Copy link

@roachmd roachmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

@spiffxp
Copy link
Member Author

spiffxp commented Aug 27, 2018

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 27, 2018
@k8s-ci-robot k8s-ci-robot merged commit 02bf0c9 into kubernetes:master Aug 27, 2018
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Updated the config configmap using the following files:

  • key config.yaml using file prow/config.yaml

In response to this:

Every repo already should have cla/linuxfoundation as required, but there are
a number that don't. This fixes that.

Repos that have other required status contexts have those enabled as well

ref: #6227

/hold
for comment / lazy consensus, no objections by friday 10am PT and I'll merge this

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp spiffxp deleted the branch-protect-all-k8s-orgs branch August 27, 2018 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants