Disable the cache mutation detector. #9201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ENABLE_CACHE_MUTATION_DETECTOR` has been set for over a year, but due to a bug in the script parsing it, has not actually run. Fixing the bug such that it can run makes the tests time out. Since an hour is already a long time for presubmit tests, let's not make them longer and instead just stop enabling this. See kubernetes/kubernetes#67919 for more context.
k8s-ci-robot
added
cncf-cla: yes
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
|
will this affect other ongoing PRs? |
|
In principle, this is a no-op for all PRs other than kubernetes/kubernetes#67919: the current configuration is such that this is effectively ignored due to the above bugs. In practice, I could be wrong, in which case this check does exist and would be disabled for all PRs. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Katharine, krzyzacy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Thanks! 👍 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENABLE_CACHE_MUTATION_DETECTORhas been set for over a year. However, a week after it was set, a bug inconfigure-helper.shwas introduced causing its value to be ignored. Fixing the bug such that it can run makes the tests time out. Since an hour is already a long time for presubmit tests, let's not make them even longer and instead just stop pretending that this works.Note that this will have no effect due to a another bug in the default configuration, which sets
ENABLE_CACHE_MUTATION_DETECTOR=false, which is a non-empty string and will therefore cause it to be enabled anyway regardless of what is set here.Both of the above bugs are fixed in kubernetes/kubernetes#67919, but that cannot pass tests as long as this is enabled here due to the aforementioned timeouts.
(There is some degree of conjecture in this, since I do not know of a good way to run these tests with this flag changed other than by actually doing it.)