Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional presubmit pull-kubernetes-e2e-gce-alpha-features tests #9943

Merged
merged 1 commit into from
Oct 30, 2018
Merged

Add optional presubmit pull-kubernetes-e2e-gce-alpha-features tests #9943

merged 1 commit into from
Oct 30, 2018

Conversation

wangzhen127
Copy link
Member

This PR adds optional presubmit pull-kubernetes-e2e-gce-alpha-features tests.

This is part of KEP-0009, feature #589 and issue #14733.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config area/testgrid size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 28, 2018
@wangzhen127 wangzhen127 mentioned this pull request Oct 28, 2018
Merged
@wangzhen127
Copy link
Member Author

This can be used to check the NodeLease e2e tests are passing.

/assign Sen Lu
/assign Yu-Ju Hong
/cc Wojciech Tyczynski

@k8s-ci-robot
Copy link
Contributor

@wangzhen127: GitHub didn't allow me to assign the following users: Sen, Lu, Yu-Ju, Hong.

Note that only kubernetes members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

This can be used to check the NodeLease e2e tests are passing.

/assign Sen Lu
/assign Yu-Ju Hong
/cc Wojciech Tyczynski

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@wangzhen127: GitHub didn't allow me to request PR reviews from the following users: Wojciech, Tyczynski.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

This can be used to check the NodeLease e2e tests are passing.

/assign Sen Lu
/assign Yu-Ju Hong
/cc Wojciech Tyczynski

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wangzhen127
Copy link
Member Author

/assign @krzyzacy
/assign @yujuhong
/cc @wojtek-t

@wangzhen127 wangzhen127 mentioned this pull request Oct 28, 2018
Merged
@yujuhong
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2018
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 73adbce89f323490f73e5ebd4aa953f203aa6041

@krzyzacy
Copy link
Member

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krzyzacy, wangzhen127, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2018
@k8s-ci-robot k8s-ci-robot merged commit 0daf263 into kubernetes:master Oct 30, 2018
@k8s-ci-robot
Copy link
Contributor

@wangzhen127: Updated the job-config configmap using the following files:

  • key generated-security-jobs.yaml using file config/jobs/kubernetes-security/generated-security-jobs.yaml
  • key sig-gcp-gce-config.yaml using file config/jobs/kubernetes/sig-gcp/sig-gcp-gce-config.yaml

In response to this:

This PR adds optional presubmit pull-kubernetes-e2e-gce-alpha-features tests.

This is part of KEP-0009, feature #589 and issue #14733.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wangzhen127 wangzhen127 deleted the add-alpha-feature-presubmit branch October 30, 2018 00:02
krzyzacy
krzyzacy reviewed Oct 30, 2018
View reviewed changes
config/jobs/kubernetes/sig-gcp/sig-gcp-gce-config.yaml
containers:
- args:
- --root=/go/src
- --repo=k8s.io/kubernetes=$(PULL_REFS)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, also add --repo=k8s.io/release so you can stage your local build.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Created a fix PR at: #9957

@aojea aojea mentioned this pull request Apr 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzyzacy krzyzacy krzyzacy left review comments

@dashpole dashpole Awaiting requested review from dashpole

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@krzyzacy krzyzacy

@yujuhong yujuhong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wangzhen127 @k8s-ci-robot @yujuhong @krzyzacy