Issue with k8s.io/docs/concepts/workloads/controllers/replicaset/

[erkanerol]

This is a...

• Feature Request
• [ x] Bug Report

Problem:
It seems replicasets use ownerReferences and they ignore the other's pod even the labels match their selector. There is nothing in the documentation regarding this.

Here is a stackoverflow issue:
https://stackoverflow.com/questions/54172198/why-dont-two-kubernetes-replicasets-with-same-selector-conflict-with-each-other/54172659#54172659

Proposed Solution:
Please state that replicasets ignore a pod if it belongs someone else.

Page to Update:
https://kubernetes.io/...

[SupriyaSirbi]

Hello,

Could you please assign it to me?

Thanks

[tengqm]

/assign @SupriyaSirbi

[k8s-ci-robot]

@tengqm: GitHub didn't allow me to assign the following users: SupriyaSirbi.

Note that only kubernetes members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @SupriyaSirbi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tengqm]

@SupriyaSirbi Cannot assign it to you because you are not a kubernetes member. However, you can still work on it and propose a PR.

[SupriyaSirbi]

Thanks for your support. I shall work on the same and propose a PR

[SupriyaSirbi]

Hello @tengqm and @erkanerol

I am planning to update the docs with the following change. Please review and let me know if this is fine

Link:

Original :
Note: For some API types, such as ReplicaSets, the label selectors of two instances must not overlap within a namespace, or the controller can see that as conflicting instructions and fail to determine how many replicas should be present.

Proposed Solution:
Note: For some API types, such as ReplicaSets, the label selectors of two instances might overlap within a namespace. In this case , the controller can ignore a pod if it belongs someone else i.e having different metadata and spec fields in the namespace and create the replicas.

[SupriyaSirbi]

Added Link https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/

[erkanerol]

Hi @SupriyaSirbi

I am not sure whether it should be stated in labels page or replicasets page. Since I have no holistic view of k8s documents, I cannot comment on it.

However, I believe there should be a statement like yours somewhere.

[SupriyaSirbi]

@erkanerol Thanks for your suggestion

I came across the following the the replicaset page in "Pod Selector" section

https://kubernetes.io/docs/concepts/workloads/controllers/replicaset/

Also you should not normally create any pods whose labels match this selector, either directly, with another ReplicaSet, or with another controller such as a Deployment. If you do so, the ReplicaSet thinks that it created the other pods. Kubernetes does not stop you from doing this.

If you do end up with multiple controllers that have overlapping selectors, you will have to manage the deletion yourself.

This internally means that the replicasets ignore a pod if it belongs someone else? Should i just add a statement here like this after the bold statement as

In this case , the controller can ignore a pod if it belongs someone else i.e having different metadata and spec fields in the namespace and create the replicas.

[SupriyaSirbi]

Hello @tengqm I am not finding any reviewers for this issue.. This issue is open since last week. Could you please suggest any reviewers for the same?

[tengqm]

@SupriyaSirbi Since you have already assigned some reviewers, let's wait and see if we can get some comments.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[erkanerol]

@SupriyaSirbi I checked the doc. It seems fine. Thanks a lot!