Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistency with footer navigation tabs #12823

Closed
1 of 2 tasks
daminisatya opened this issue Feb 25, 2019 · 10 comments
Closed
1 of 2 tasks

Inconsistency with footer navigation tabs #12823

daminisatya opened this issue Feb 25, 2019 · 10 comments
Assignees
@balajismaniam @daminisatya
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@daminisatya
Copy link
Contributor

This is a...

  • Feature Request
  • Bug Report

Problem:
The footer nav tabs in the blog are in blue whereas in the rest of the document they are in white.

Proposed Solution:
The color should be consistent across the pages in the white.

Footer in Blog
screen shot 1940-12-06 at 5 49 30 pm

Expected

screen shot 1940-12-06 at 5 49 40 pm

Page to Update:
https://kubernetes.io/blog/
@daminisatya
Copy link
Contributor Author

/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@daminisatya:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Feb 25, 2019
Abhik1998 added a commit to Abhik1998/website that referenced this issue Feb 26, 2019
@Abhik1998
Update footer
d761402 
Addressing to issue kubernetes#12823
This was referenced Feb 26, 2019
Closed
Closed
@Sai-Adarsh
Copy link
Contributor

I shall work on this, Any more pointers @balajismaniam @daminisatya ?

@Sai-Adarsh
Copy link
Contributor

/assign @balajismaniam

@Sai-Adarsh
Copy link
Contributor

/assign @daminisatya

@daminisatya
Copy link
Contributor Author

@Sai-Adarsh Feel free to open a PR. We have a fix from @Abhik1998. I left some comments on his PR. If you can address those it would be great! Thank you ✨

@daminisatya
Copy link
Contributor Author

#12842 (comment)

This was referenced Mar 10, 2019
Closed
Closed
Merged
@thecrudge
Copy link
Contributor

/close

@k8s-ci-robot
Copy link
Contributor

@thecrudge: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kbhawkey
Copy link
Contributor

/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@balajismaniam balajismaniam

@daminisatya daminisatya

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@kbhawkey @balajismaniam @daminisatya @k8s-ci-robot @Sai-Adarsh @thecrudge