Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whenever possible, limit PRs to one language #15762

Closed
zacharysarah opened this issue Aug 9, 2019 · 4 comments · Fixed by #15773
Closed

Whenever possible, limit PRs to one language #15762

zacharysarah opened this issue Aug 9, 2019 · 4 comments · Fixed by #15773
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/docs Categorizes an issue or PR as relevant to SIG Docs.

Comments

@zacharysarah
Copy link
Contributor

Please add the following language to the contribution guide, step 5 of "Submit a pull request":

{{< note >}}

Please limit pull requests to one language per PR. For example, if you need to make an identical change to the same code sample in multiple languages, open a separate PR for each language. 

{{< /note >}}

/good-first-issue
/sig docs
/priority important-soon

@k8s-ci-robot
Copy link
Contributor

@zacharysarah:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

Please add the following language to the contribution guide, step 5 of "Submit a pull request":

{{< note >}}

Please limit pull requests to one language per PR. For example, if you need to make an identical change to the same code sample in multiple languages, open a separate PR for each language. 

{{< /note >}}

/good-first-issue
/sig docs
/priority important-soon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Aug 9, 2019
@aimeeu
Copy link
Contributor

aimeeu commented Aug 9, 2019

/assign

@aimeeu
Copy link
Contributor

aimeeu commented Aug 9, 2019

/unassign

@k8s-ci-robot
Copy link
Contributor

@aimeeu: GitHub didn't allow me to assign the following users: MaxKam.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @MaxKam

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/docs Categorizes an issue or PR as relevant to SIG Docs.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants