Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EndpointSlice concept prioritised ahead of Service #18628

Closed
sftim opened this issue Jan 11, 2020 · 20 comments · Fixed by #20072
Closed

EndpointSlice concept prioritised ahead of Service #18628

sftim opened this issue Jan 11, 2020 · 20 comments · Fixed by #20072
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. language/en Issues or PRs related to English language priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@sftim
Copy link
Contributor

sftim commented Jan 11, 2020

This is a Bug Report

Problem:
https://kubernetes.io/docs/concepts/services-networking/ lists the EndpointSlice concept before Service.

Although the Service page needs work, the current page about Service should come before the page about EndpointSlice, which is still beta and only partly activated by default.

Proposed Solution:
Revise the EndpointSlice page to have a weight that is higher than the Service page. See https://github.com/kubernetes/website/blame/55ee59477ec2b82df778b16e4293ecc89bdacdb3/content/en/docs/concepts/services-networking/endpoint-slices.md#L11 for the line that needs tweaking.

Page to Update:
https://kubernetes.io/docs/concepts/services-networking/endpoint-slices/

Kubernetes Version:
v1.18

Additional Information:
/language en

@k8s-ci-robot
Copy link
Contributor

@sftim:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

This is a Bug Report

Problem:
https://kubernetes.io/docs/concepts/services-networking/ lists the EndpointSlice concept before Service.

Although the Service page needs work, the current page about Service should come before the page about EndpointSlice, which is still beta and only partly activated by default.

Proposed Solution:
Revise the EndpointSlice page to have a weight that is higher than the Service page. See https://github.com/kubernetes/website/blame/55ee59477ec2b82df778b16e4293ecc89bdacdb3/content/en/docs/concepts/services-networking/endpoint-slices.md#L11 for the line that needs tweaking.

Page to Update:
https://kubernetes.io/docs/concepts/services-networking/endpoint-slices/

Kubernetes Version:
v1.17

Additional Information:
/language en
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jan 11, 2020
@sftim
Copy link
Contributor Author

sftim commented Jan 11, 2020

This is a good first issue; if you've already had a pull request or two merged, I recommend leaving this one so that it's saved for a new contributor.

@zacharysarah
Copy link
Contributor

@sftim Thanks for triaging with an eye for new contributors! 🌟

@makiw
Copy link

makiw commented Jan 15, 2020

@sftim I'd like to work on this issue, as a new contributor.

@sftim
Copy link
Contributor Author

sftim commented Jan 15, 2020

@makiw it'll be great to have your input
Have you already seen https://k8s.io/docs/contribute/?

@makiw
Copy link

makiw commented Jan 15, 2020

@sftim Yes, I've read the docs and signed CLA already.

@makiw
Copy link

makiw commented Jan 16, 2020

@sftim I'd like to work on this issue, as a new contributor.

Retract my application as it seem I haven't meet some of requirements described in https://github.com/kubernetes/community/blob/master/community-membership.md

@rahulrai-in
Copy link

If it is okay, I would like to take this up. Thanks.

@rahulrai-in
Copy link

/assign

@omkensey
Copy link

This also looks like maybe it affects the rendering of the main Kubernetes web page at https://kubernetes.io/ also, actually -- under Features, EndpointSlices is listed before Service Topology (in fact EndpointSlices is the very first feature listed).

@rahulrai-in
Copy link

Thanks for pointing that out @omkensey. I will put that list in the same sequence as documentation. I am planning to work on it this weekend.

@ashishsingh2k8
Copy link

@rahulrai-in are you working on this issue? if not I would like to take this.

Please let me know

@rahulrai-in
Copy link

@ashishsingh2k8 I planned to work on it during my break but couldn't find much time to tend to it. Please feel free to take this up. I will circle back to this issue on March 1 when I have some capacity to spare. Thanks.

@ashishsingh2k8
Copy link

/assign

@rahulrai-in
Copy link

Hi, @ashishsingh2k8 I am back from my holidays. Are you still working on this issue or would you like me to take it forward? Thanks.

@ashishsingh2k8
Copy link

ashishsingh2k8 commented Mar 1, 2020 via email

@sftim
Copy link
Contributor Author

sftim commented Mar 7, 2020

/priority important-longterm

@k8s-ci-robot k8s-ci-robot added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Mar 7, 2020
@sftim
Copy link
Contributor Author

sftim commented Apr 2, 2020

@prasadkatti I noticed you were just working in this area - would you like to pick this issue up as well?

@prasadkatti
Copy link
Contributor

prasadkatti commented Apr 2, 2020 via email

@prasadkatti
Copy link
Contributor

prasadkatti commented Apr 2, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. language/en Issues or PRs related to English language priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants