Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow switching website between “light mode” and “dark mode” #25061

Open
mhrbmr opened this issue Nov 16, 2020 · 30 comments
Open

Allow switching website between “light mode” and “dark mode” #25061

mhrbmr opened this issue Nov 16, 2020 · 30 comments
Assignees
Labels
area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@mhrbmr
Copy link

mhrbmr commented Nov 16, 2020

Needs a dark mode for enhanced accessibility.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Nov 16, 2020
@sftim
Copy link
Contributor

sftim commented Nov 19, 2020

/retitle Allow switching website between “light mode” and “dark mode”

/kind feature
/area web-development
/priority awaiting-more-evidence

@k8s-ci-robot k8s-ci-robot changed the title Interactive Tutorial - Creating a Cluster Allow switching website between “light mode” and “dark mode” Nov 19, 2020
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. labels Nov 19, 2020
@sftim
Copy link
Contributor

sftim commented Nov 19, 2020

@HBDUDE interesting idea. If this gets a few 👍 reactions we'll be happy to accept it as a feature for the backlog.

@zaheeruddinfaiz
Copy link

It would be great to have such an option. Since reading the documentation, the dark mode helps in reading for longer period of time.

@wethinkagile
Copy link

It would save energy, too.

@mhrbmr
Copy link
Author

mhrbmr commented May 4, 2021

Just in curiosity, because I’m new to open source software, but does that mean anyone can potentially contribute? Say if someone wanted to build a dark mode out and then submitted it for review, would that be something someone could do?

@wethinkagile
Copy link

wethinkagile commented May 4, 2021

Indeed, you can and it will be much appreciated. I already started working on it. If you want to coordinate and help, let me know. I also recommend checking out the project and reading the Readme, you will see links to Slack and Mailinglist there.

@mhrbmr
Copy link
Author

mhrbmr commented May 4, 2021

Ok, that’s really cool to know. Im not extremely experienced as a dev yet, and so I don’t know if I’d be of much use, but I’d love to check out the code and see how it goes.

@sftim
Copy link
Contributor

sftim commented May 27, 2021

/priority backlog
/remove-priority awaiting-more-evidence
/triage accepted

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 27, 2021
@vickyvikas7988
Copy link

+1
Need dark mode for documentation

@wethinkagile
Copy link

wethinkagile commented Jun 23, 2021 via email

@sftim
Copy link
Contributor

sftim commented Jun 24, 2021

@stevek-pro this is a backlog priority issue. SIG Docs has a really chunky amount of work that we've triaged as more valuable, so it's likely that this will move forward specifically when someone who wants to see this specific improvement land picks it up.

If we don't see any movement within a few months, we have a bot that would close the feature request.

@sftim
Copy link
Contributor

sftim commented Jun 25, 2021

See https://stuffandnonsense.co.uk/blog/redesigning-your-product-and-website-for-dark-mode for a CSS approach towards implementing this.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 23, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 23, 2021
@wethinkagile
Copy link

See https://stuffandnonsense.co.uk/blog/redesigning-your-product-and-website-for-dark-mode for a CSS approach towards implementing this.

Thanks. I will look into it.

@sftim
Copy link
Contributor

sftim commented Oct 26, 2021

/remove-lifecycle rotten
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Oct 26, 2021
@sftim
Copy link
Contributor

sftim commented Apr 26, 2022

Any implementation of this needs to work for diagrams and other graphics, as well as text. We don't want to have people who prefer dark mode missing out on being able to see what a diagram says.

@wethinkagile
Copy link

Sorry I did not follow up earlier, but since I discovered dark reader plugin, I am in no need of this feature anymore.

@sftim
Copy link
Contributor

sftim commented Apr 29, 2022

As well as using CSS, if we find we need JavaScript for some aspect then that's also feasible, eg https://flaviocopes.com/javascript-detect-dark-mode/

@sftim
Copy link
Contributor

sftim commented Feb 5, 2023

Duplicated by #39263

@KhushPatibandha
Copy link
Contributor

I don't see any dark mode button on the kubernetes website, so i suppose this issue is still not resolved? so can I work on this? I think I can help.
Do let me know.

@KhushPatibandha
Copy link
Contributor

/assign

@KhushPatibandha
Copy link
Contributor

can someone help me locate the main css file which is relevant to make a change in?

@sftim
Copy link
Contributor

sftim commented Apr 20, 2023

can someone help me locate the main css file which is relevant to make a change in?

assets/scss/_base.scss

This is SCSS, not CSS.

If you're planning to work on #37444, try selecting body.td-home (or children), and using the appropriate media query.

@Gauravpadam
Copy link
Member

Hey @KhushPatibandha, I see that you're working on this feature. Would you like to collaborate on a PR?

@sftim
Copy link
Contributor

sftim commented Sep 18, 2023

Also see #43084

@sftim
Copy link
Contributor

sftim commented Nov 30, 2023

Duplicated by #44159

@sftim
Copy link
Contributor

sftim commented Nov 30, 2023

Help is welcome. Please consider working on #37444 first.

@dipesh-rawat
Copy link
Member

Another duplicate request #44323

@sftim
Copy link
Contributor

sftim commented Feb 25, 2024

Help is welcome. Please consider working on #37444 first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants