Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advice in “Configuring Redis using a ConfigMap” not quite correct #37331

Open
olekszhel opened this issue Oct 16, 2022 · 7 comments
Open
Labels
language/en Issues or PRs related to English language lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@olekszhel
Copy link

The configuration values have not changed because the Pod needs to be restarted to grab updated values from associated ConfigMaps.

This is not correct really and leads to confusion. As configmap is mounted as a volume it automatically updates appropriate config file inside pod. But redis application itself is not configured to update config automatically. It really creates wrong imagination about core topic (configmap). That's why I believe redis is not a good example to demonstrate that configmap automatically updates config inside pod and it doesn't required pod recreation.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Oct 16, 2022
@Shubham82
Copy link
Contributor

@sftim
Copy link
Contributor

sftim commented Oct 18, 2022

/retitle Advice in “Configuring Redis using a ConfigMap” not quite correct
/language en

@k8s-ci-robot k8s-ci-robot changed the title Configuring Redis using a ConfigMap Advice in “Configuring Redis using a ConfigMap” not quite correct Oct 18, 2022
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Oct 18, 2022
@sftim
Copy link
Contributor

sftim commented Oct 18, 2022

The configuration values have not changed because the Pod needs to be restarted to grab updated values from associated ConfigMaps.

This sentence is true, but we could explain more about the context that makes it true.

@RA489
Copy link

RA489 commented Oct 28, 2022

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 28, 2022
@yashodhanmohan
Copy link
Contributor

Would it help here to add an additional demonstration step that the underlying redis.conf did indeed update but that the Redis configuration didn't change because it needs to restart to pick the new values? I can pick it up @sftim if the change is acceptable. Let me know if there might be a simpler update to this.

@k8s-triage-robot
Copy link

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

  • Confirm that this issue is still relevant with /triage accepted (org members only)
  • Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. and removed triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Jan 19, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language/en Issues or PRs related to English language lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

7 participants