Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default secret with token for service account is not the default behavior #37393

Open
srm09 opened this issue Oct 19, 2022 · 7 comments
Open
Labels
kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@srm09
Copy link
Contributor

srm09 commented Oct 19, 2022

With 1.24, the LegacyServiceAccountTokenNoAutoGeneration feature gate is beta and enabled by default. This stops the auto generation of secrets containing service account token for every ServiceAccount.
Bu the docs on the site refer to the previous assumption that a token gets created by default for all service accounts.

Problematic line: A controller loop ensures a Secret with an API token exists for each ServiceAccount.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Oct 19, 2022
@srm09
Copy link
Contributor Author

srm09 commented Oct 19, 2022

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 19, 2022
@Shubham82
Copy link
Contributor

I think this is relevant to #31847
Here is google docs open for improvement of the service account. It also contains this part.

@sftim
Copy link
Contributor

sftim commented Oct 20, 2022

/triage accepted

/language en

The one-line fix you suggested seems reasonable, @srm09

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. language/en Issues or PRs related to English language and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 20, 2022
@sftim
Copy link
Contributor

sftim commented Nov 8, 2022

Hey, @sftim I would like to work on this issue can you please guide me? Are you expecting to replace the line like this? or completely remove it.

Hi. I'm not sure I'd have time to provide guidance specifically on this issue. Could you ask in Slack - see https://slack.k8s.io/ for an invitation - in the #sig-docs channel? I hope if you ask questions there, someone is willing to help you learn how to contribute here.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 6, 2023
@adityasamant25
Copy link
Contributor

@srm09 This is addressed in the newer documentation. Can you please recheck and close the issue?

@divya-mohan0209
Copy link
Contributor

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

7 participants