Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation about imagePullPolicy confuses readers #38005

Closed
rinocata opened this issue Nov 21, 2022 · 16 comments
Closed

Documentation about imagePullPolicy confuses readers #38005

rinocata opened this issue Nov 21, 2022 · 16 comments
Labels
language/en Issues or PRs related to English language needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. triage/duplicate Indicates an issue is a duplicate of other open issue.

Comments

@rinocata
Copy link

The section on imagePullPolicy seems to be misleading. Always seems to, well, always pull images no matter what despite what the description says.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Nov 21, 2022
@k8s-ci-robot
Copy link
Contributor

@rinocata: This issue is currently awaiting triage.

SIG Docs takes a lead on issue triage for this website, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mengjiao-liu
Copy link
Member

@k8s-ci-robot k8s-ci-robot added the kind/support Categorizes issue or PR as a support question. label Nov 22, 2022
@utkarsh-singh1
Copy link
Contributor

/language en

Hi @rinocata, always value of imagePullPolicy ensures that the latest image of container is present every time you create, deploy or run the pod.

You can find more details about the default value of imagePullPolicy here - https://kubernetes.io/docs/concepts/containers/images/#imagepullpolicy-defaulting

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Nov 22, 2022
@rinocata
Copy link
Author

You seem to be correct @utkarsh-singh1 but the page you linked contradicts the one @mengjiao-liu (thanks) posted.

If the kubelet has a container image with that exact digest cached locally, the kubelet uses its cached image

This seems to be the behavior of IfNotPresent, not Always.

@rinocata
Copy link
Author

Also, it's not dependent on container runtime, same behavior occurs with containerd and CRI-O. My guess is simply unverified or outdated information.

@sftim
Copy link
Contributor

sftim commented Nov 22, 2022

Also, it's not dependent on container runtime, same behavior occurs with containerd and CRI-O. My guess is simply unverified or outdated information.

Although two container runtimes both behave a particular way, that doesn't mean we can conclude they all behave that way.

Issue 37926 is very similar to this.

/remove-kind support
/triage duplicate

@k8s-ci-robot k8s-ci-robot added triage/duplicate Indicates an issue is a duplicate of other open issue. and removed kind/support Categorizes issue or PR as a support question. labels Nov 22, 2022
@rinocata
Copy link
Author

Fair enough, the documentation is misleading in any case.

@sftim
Copy link
Contributor

sftim commented Nov 23, 2022

/retitle Documentation about imagePullPolicy confuses readers

@k8s-ci-robot k8s-ci-robot changed the title Images Documentation about imagePullPolicy confuses readers Nov 23, 2022
@sftim
Copy link
Contributor

sftim commented Nov 23, 2022

I'd like to see some evidence that the existing text is factually incorrect. I'm very willing to accept that it's not easy to understand, but I believe that it's not actually wrong.

@rinocata
Copy link
Author

Would kubectl describe pod logs constitute evidence?

@sftim
Copy link
Contributor

sftim commented Nov 23, 2022

Would kubectl describe pod logs constitute evidence?

The way I'm imagining this, you'd also need to show the state of the image cache for the container runtime used on that node before the Pod was scheduled there.

@sftim
Copy link
Contributor

sftim commented Nov 23, 2022

Please add any evidence to #37926 (which this issue pretty much duplicates)

@rinocata
Copy link
Author

rinocata commented Nov 23, 2022

show the state of the image cache for the container runtime

Would crictl output be enough?

@sftim
Copy link
Contributor

sftim commented Nov 23, 2022

Let's continue discussion in issue #37926

@mehabhalodiya
Copy link
Contributor

Per this comment, I am closing this issue. Thanks!

/close

@k8s-ci-robot
Copy link
Contributor

@mehabhalodiya: Closing this issue.

In response to this:

Per this comment, I am closing this issue. Thanks!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language/en Issues or PRs related to English language needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. triage/duplicate Indicates an issue is a duplicate of other open issue.
Projects
None yet
Development

No branches or pull requests

6 participants