Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit RSS feed to 10 items and use the rssLimit var. #39684

Open
dradetsky opened this issue Feb 26, 2023 · 3 comments
Open

Limit RSS feed to 10 items and use the rssLimit var. #39684

dradetsky opened this issue Feb 26, 2023 · 3 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@dradetsky
Copy link
Contributor

I created PR #36252 to make the above changes, but was told by another contributor that I was supposed to create an issue describing the proposed changes. Sure, why not:

First, the k8s rss feed is too big. It's ~800kb every time I run a feed check, which can be problematic in certain circumstances, like if I haven't (or can't) configure my reader to check feeds in parallel, or I just have slow internet. And it extends back to midway through last year. A user almost always wants to catch up the last few articles she might have missed, not populate a local copy of the last 1-2 years worth of k8s blog posts. So we reduce the number of items emitted from 50 to 10.

Second, let's say in the future somebody said "We should actually bump it back up to 20 items" (not an unreasonable compromise). He would probably go looking in the Hugo docs and see the rssLimit variable documented and attempt to set it, and be confused as to why it wasn't changing (or wasn't already set). So we change the template to use this variable in order to be Hugo-idiomatic.

@dradetsky dradetsky added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 26, 2023
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Feb 26, 2023
@tengqm
Copy link
Contributor

tengqm commented Feb 27, 2023

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 27, 2023
@k8s-triage-robot
Copy link

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

  • Confirm that this issue is still relevant with /triage accepted (org members only)
  • Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. and removed triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Feb 27, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

4 participants