Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document conditions as a Kubernetes concept #41065

Open
sftim opened this issue May 10, 2023 · 12 comments
Open

Document conditions as a Kubernetes concept #41065

sftim opened this issue May 10, 2023 · 12 comments
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. language/en Issues or PRs related to English language lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@sftim
Copy link
Contributor

sftim commented May 10, 2023

This is a Feature Request

What would you like to be added

  • Add a page, or section of an existing page, about conditions in Kubernetes
    • Ideally, also mention reasons.
  • Add a glossary entry that references that section

Extra credit: revise existing mentions such as https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#pod-conditions to use a glossary tooltip for the new entry.

Why is this needed
People might want to know what conditions are.
Docs authors might want to use a glossary tooltip for condition rather than explain each time.

Comments
Not sure what conditions are? Please read - but don't plagiarize - https://maelvls.dev/kubernetes-conditions/

/language en
/priority backlog
/lifecycle frozen
/sig architecture

@sftim sftim added the kind/feature Categorizes issue or PR as related to a new feature. label May 10, 2023
@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. language/en Issues or PRs related to English language priority/backlog Higher priority than priority/awaiting-more-evidence. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 10, 2023
@sftim
Copy link
Contributor Author

sftim commented May 10, 2023

/triage accepted
/help

@k8s-ci-robot
Copy link
Contributor

@sftim:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/triage accepted
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 10, 2023
@sftim
Copy link
Contributor Author

sftim commented May 10, 2023

@reetasingh
Copy link
Contributor

/assign

@sftim
Copy link
Contributor Author

sftim commented May 16, 2023

Hi @reetasingh

Would you like any help or advice to work on this issue?

@reetasingh
Copy link
Contributor

Hi @reetasingh

Would you like any help or advice to work on this issue?

Hi @sftim
Yes I do have some questions.

  1. If we want to add a section to existing page, which page would be appropriate for this?
  2. Are we supposed to cover conditions in generic way? or should it be specific to a resource eg: Pod

@sftim
Copy link
Contributor Author

sftim commented May 17, 2023

If we want to add a section to existing page, which page would be appropriate for this?

I'd make a new page, with the URI:
https://kubernetes.io/docs/concepts/overview/working-with-objects/conditions/

If we add this page, consider also editing https://kubernetes.io/docs/concepts/overview/working-with-objects/#object-spec-and-status to link to it.

Are we supposed to cover conditions in generic way? or should it be specific to a resource eg: Pod

Generically

@a-hilaly
Copy link
Member

Could be wroth it to take a look at kubernetes/enhancements#2537 and kubernetes/enhancements#2527

@sftim
Copy link
Contributor Author

sftim commented Aug 8, 2023

@a-hilaly I don't understand for whom you're saying it might be worth a look. Can you clarify?

@vaibhav2107
Copy link
Member

@reetasingh Are you still working on this issue ?

@sftim
Copy link
Contributor Author

sftim commented Jun 1, 2024

If anyone would like to open a pull request to help with this, that would be helpful.

@120EE0980
Copy link

@sftim I would like to work on this issue,will open pull request soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. language/en Issues or PRs related to English language lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

6 participants