Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with k8s.io/docs/tasks/administer-cluster/kubeadm/adding-windows-nodes/ #45499

Closed
Khaos66 opened this issue Mar 11, 2024 · 8 comments
Closed
Labels
area/localization General issues or PRs related to localization kind/support Categorizes issue or PR as a support question. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. triage/needs-information Indicates an issue needs more information in order to work on it.

Comments

@Khaos66
Copy link

Khaos66 commented Mar 11, 2024

This is a Bug Report

Problem:
The StartKubelet.ps1 created by PrepareNode.ps1 still includes the --log-dir and --logtostderr cli attributes, which are depricated for some time and removed in current versions of kubelet.

Proposed Solution:
Add a hint on that issue, as it's hard to diagnose for newbies (no logs are written anywhere)

Page to Update:
https://kubernetes.io/...

@Khaos66 Khaos66 added the kind/bug Categorizes issue or PR as related to a bug. label Mar 11, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

SIG Docs takes a lead on issue triage for this website, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Mar 11, 2024
@dipesh-rawat
Copy link
Member

@Khaos66 Could you please provide the exact URL of the page you're referring to from the Kubernetes documentation? This will help us understand the context better and address the issue effectively.

/triage needs-information

@k8s-ci-robot k8s-ci-robot added the triage/needs-information Indicates an issue needs more information in order to work on it. label Mar 11, 2024
@Khaos66
Copy link
Author

Khaos66 commented Mar 11, 2024

@sftim
Copy link
Contributor

sftim commented Mar 11, 2024

Hi. That website is not the Kubernetes documentation (it's a stale copy).

See https://k8s.io/docs/setup/production-environment/tools/kubeadm/create-cluster-kubeadm/#joining-a-windows-worker-node

/kind support

@k8s-ci-robot k8s-ci-robot added the kind/support Categorizes issue or PR as a support question. label Mar 11, 2024
@sftim
Copy link
Contributor

sftim commented Mar 11, 2024

/area localization

@k8s-ci-robot k8s-ci-robot added the area/localization General issues or PRs related to localization label Mar 11, 2024
@sftim
Copy link
Contributor

sftim commented Mar 11, 2024

/remove-kind bug

@k8s-ci-robot k8s-ci-robot removed the kind/bug Categorizes issue or PR as related to a bug. label Mar 11, 2024
@neolit123
Copy link
Member

The StartKubelet.ps1 created by PrepareNode.ps1 still includes the --log-dir and --logtostderr cli attributes, which are depricated for some time and removed in current versions of kubelet.

this should be logged as a ticket in
https://github.com/kubernetes-sigs/sig-windows-tools

https://github.com/kubernetes-sigs/sig-windows-tools/blob/dcc77000dc7ea1ec35a1bd5877c660edc4c37310/hostprocess/PrepareNode.ps1#L81

@Khaos66
Copy link
Author

Khaos66 commented Mar 11, 2024

Thanks for all the nice feedback. Closing this now

@Khaos66 Khaos66 closed this as completed Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/localization General issues or PRs related to localization kind/support Categorizes issue or PR as a support question. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. triage/needs-information Indicates an issue needs more information in order to work on it.
Projects
None yet
Development

No branches or pull requests

5 participants