Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set text direction based on localization text direction #46100

Open
sftim opened this issue May 1, 2024 · 4 comments
Open

Set text direction based on localization text direction #46100

sftim opened this issue May 1, 2024 · 4 comments
Labels
area/localization General issues or PRs related to localization help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@sftim
Copy link
Contributor

sftim commented May 1, 2024

This is a Feature Request

What would you like to be added
Edit the Hugo layout template(s) for the site to set dir on the html element, so that browsers know what text direction is in use.

Why is this needed
This change would support or enable #22730 and #46042

Comments
/area localization
/kind feature
/help
/triage accepted

You should work on this if you have the capacity to and you already understand a little about Hugo templating. The change may not be suitable for a contributor who is new to working with Hugo and Hugo themes.

@sftim sftim added the kind/feature Categorizes issue or PR as related to a new feature. label May 1, 2024
@k8s-ci-robot
Copy link
Contributor

@sftim:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

This is a Feature Request

What would you like to be added
Edit the Hugo layout template(s) for the site to set dir on the html element, so that browsers know what text direction is in use.

Why is this needed
This change would support or enable #22730 and #46042

Comments
/area localization
/kind feature
/help
/triage accepted

You should work on this if you have the capacity to and you already understand a little about Hugo templating. The change may not be suitable for a contributor who is new to working with Hugo and Hugo themes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/localization General issues or PRs related to localization help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels May 1, 2024
@sftim
Copy link
Contributor Author

sftim commented May 1, 2024

/priority backlog

@k8s-ci-robot k8s-ci-robot added the priority/backlog Higher priority than priority/awaiting-more-evidence. label May 1, 2024
@sftim
Copy link
Contributor Author

sftim commented May 1, 2024

@mariasalcedo
Copy link
Contributor

Can I help on this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/localization General issues or PRs related to localization help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

3 participants