-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document canonical way to set priority for static pods #46859
Comments
/language en |
Page related to the issue: https://kubernetes.io/docs/concepts/scheduling-eviction/node-pressure-eviction/#pod-selection-for-kubelet-eviction /sig node |
What's the defect @stackbaek? Are you saying that the docs are incorrect, that there is a bug in the kubelet, or that there is a problem but you are not sure where? |
The instruction to add priority to static pods is unclear from the doc. From the doc, it implies that I should just add At the end of the day, I just want to confirm the canonical way to set priority on the static pods to ensure node critical pods are running under node pressure. NOTE: I have not tried to set just |
/retitle Document canonical way to set priority for static pods |
priority
fails
/kind bug /priority backlog |
The necessary information needs to be added, and the documentation should be corrected. I'd want to hear from more people too. |
/assign |
@SergeyKanzhelev I was able to create a static pod with priorityClassName and was planning on adding the example to the document. Let me know if anything else is needed or if that isn't expected behavior. I see you have this added for triage with Node bugs. k get priorityclass cat static-web.yaml k describe pod static-web-minikube Name: static-web-minikube |
@stackbaek and @sftim, I was able to confirm that using just priorityClassName on the static pods works (see example above). Since this is a concept page, we do want to add an example or not? Otherwise, it is just a quick update on the docs to use priorityClassName on the static pods as well. |
@ktvargo-ms great! examples always boosts clarity and readability (at least for me). So, I guess we don't even need the priority number, correct? Otherwise all SGTM! |
Interesting (and to me surprising); however, let's show that this works for an arbitrary Pod priority and not just a built-in one. We should also show that it'll work OK for a static Pod that starts before the control plane is healthy. |
The original issue (improper instruction) has been resolved. Would these items be better addressed in the static pod page? |
Correct. Only the priorityClassName is required. The priority number is displayed when describing the node. |
I don't get how this works if the control plane isn't up yet. That's an important consideration. |
Created 'xyz-priority' and will use that an example k get priorityclass apiVersion: v1 k describe pod static-web-minikube |
sig-node meeting notes: /triage accepted |
Per doc, static pods does not support priorityClassName field. However, when static pods are created with only
priority
values set to2000001000
(that matches withsystem-node-critical
) kubelet prints the following error:The text was updated successfully, but these errors were encountered: