fix url for 1.11 docs #10087
fix url for 1.11 docs #10087
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit c96781a https://deploy-preview-10087--kubernetes-io-master-staging.netlify.com |
There was a problem hiding this comment.
@mtaufen I guess you wanted to send this patch to 1.11 branch instead of master?
| @@ -30,7 +30,7 @@ it simplifies node deployment and configuration management. | |||
|
|
|||
| The subset of the Kubelet's configuration that can be configured via a file | |||
| is defined by the `KubeletConfiguration` struct | |||
| [here (v1beta1)](https://github.com/kubernetes/kubernetes/blob/release-1.10/pkg/kubelet/apis/kubeletconfig/v1beta1/types.go). | |||
| [here (v1beta1)](https://github.com/kubernetes/kubernetes/blob/release-1.11/pkg/kubelet/apis/kubeletconfig/v1beta1/types.go). | |||
There was a problem hiding this comment.
I guess you want to use param here.
[[params.versions]]
fullversion = "v1.11.0"
version = "v1.11"
githubbranch = "v1.11.0"
docsbranch = "release-1.11"
url = "https://kubernetes.io"
Then you don't need to hard-code the release version and modify it each release.
@chenopis the params are widely used in docs for such case, right?
There was a problem hiding this comment.
Done.
Let me know if it looks right, the only other use I saw of docsbranch was in content/en/docs/concepts/configuration/assign-pod-node.md, so I just copied that.
|
/assign @chenopis |
I think, at least in the past, updates for whatever is on the current site were sent to master, and the release branches are more like pre-release docs staging that get merged into master after a release, or something like that. It's been a little while since I encountered that so I could be wrong. |
The URL was not updated to point to release-1.11 branch when 1.11 was released. This PR updates it to use the docsbranch param, so we don't have to update it for every release.
I also miss something about the current version management mechanism. @Bradamant3 @chenopis @zacharysarah can you please give some explanation on this? Thanks! |
|
@mtaufen Heya! 👋 For fixes to the current version (in this case 1.11), please base PRs on @xiangpengzhao Thanks for the heads up! 🙇♂️ |
|
@chenopis friendly ping |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zacharysarah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
The URL was not updated to point to release-1.11 branch when 1.11 was released. This PR updates it to use the docsbranch param, so we don't have to update it for every release.
The URL was not updated to point to release-1.11 branch when 1.11 was released.