New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code style not working on kubernetes.io #10727
Conversation
Code style based on tab works on github markdown, but it is not working on kubernetes.io. In addition to that, `<your-pv-name>` argument on line 50 is hidden on kubernetes.io, because it is being processed as a HTML tag.
Deploy preview for kubernetes-io-master-staging ready! Built with commit ce50d1a https://deploy-preview-10727--kubernetes-io-master-staging.netlify.com |
Deploy preview for kubernetes-io-master-staging ready! Built with commit 1024af0 https://deploy-preview-10727--kubernetes-io-master-staging.netlify.com |
kubectl get pv | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the preview, you can see that there's too much indentation. I think this will render correctly if you keep the triple backticks, but indent the block only 4 spaces. Same applies to the two commands below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The language of the code should be specified as well. In this case it should be shell
.
```shell
kubectl get pv
@caiobrentano, One comment for you in the text. |
Indentation fix Language of the code specified
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: steveperry-53 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Code style based on tab works on github markdown, but it is not working on kubernetes.io. In addition to that,
<your-pv-name>
argument on line 50 is hidden on kubernetes.io, because it is being processed as a HTML tag.