Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pigletfly(Wang Bing) as a sig-docs-zh-reviewer #11101

Closed
wants to merge 1 commit into from

Conversation

pigletfly
Copy link
Member

I'd like to provide my reviews for Chinese translation docs.

/cc @zacharysarah @markthink

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 20, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ryanmcginnis

If they are not already assigned, you can assign the PR to them by writing /assign @ryanmcginnis in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 9e77364

https://deploy-preview-11101--kubernetes-io-master-staging.netlify.com

@tengqm
Copy link
Contributor

tengqm commented Nov 25, 2018

@pigletfly You don't have to become a member of reviewers to provide your reviews. When you have many high-quality reviews in the community, you will receive an invitation to the group. Thanks ahead for your contributions.

@tengqm tengqm closed this Nov 25, 2018
@pigletfly pigletfly deleted the add-reviewer branch November 26, 2018 11:25
@bradtopol
Copy link
Contributor

@pigletfly Please submit this as a new PR and assign me and I will approve. Sorry for the miscommunication on this.

@pigletfly pigletfly restored the add-reviewer branch November 28, 2018 03:35
@tengqm
Copy link
Contributor

tengqm commented Nov 28, 2018

@pigletfly @bradtopol was right, although we have documented criteria for this, there are exceptions sometimes.

@pigletfly pigletfly deleted the add-reviewer branch November 29, 2018 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants