Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kubelet --feature-gates and add --rotate-server-certificates #12332

Closed
wants to merge 1 commit into from
Closed

Update kubelet --feature-gates and add --rotate-server-certificates #12332

wants to merge 1 commit into from

Conversation

oke-py
Copy link
Contributor

@oke-py oke-py commented Jan 23, 2019

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 23, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ryanmcginnis

If they are not already assigned, you can assign the PR to them by writing /assign @ryanmcginnis in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jan 23, 2019
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit d8679c7

https://deploy-preview-12332--kubernetes-io-master-staging.netlify.com

@tfogo
Copy link
Contributor

tfogo commented Jan 23, 2019

Hi @oke-py, thanks for the PR. Did you manually edit this file or generate it? This file is a generated file, so if you manually edited it, your changes will be overwritten the next time it is generated.

@oke-py
Copy link
Contributor Author

oke-py commented Jan 24, 2019

@tfogo Oh, I edited this file manually. Is there anything I can do?
Which file, repo needs to be changed? Or it's OK only to wait for the update?

@Rajakavitha1
Copy link
Contributor

/assign @ryanmcginnis

@ryanmcginnis
Copy link
Contributor

i don't have enough understanding of the repo to know how to make changes to an autogenerated file... i've reassigned this PR to mistyhacks@ assuming she might know.

@zparnold
Copy link
Member

@oke-py @tfogo Kubelet generated docs I believe live in the K/K repo. So this change probable needs to be made there, then we can regenerate the docs.

@oke-py
Copy link
Contributor Author

oke-py commented Feb 13, 2019

@tfogo @zparnold Thanks for your reply. I found the generator is here.
--feature-gates probably refers to this file and the file is what I referred when editing this document.
--rotate-server-certificates description is here.
So, I think necessary changes have already been made.

@Rajakavitha1
Copy link
Contributor

@zparnold Please take a look.

@zparnold
Copy link
Member

@oke-py sounds good, so that means the next time the docs are generated (1.14 release) this site will be updated. @jimangel can follow up with more (he's the release lead)
/close

@k8s-ci-robot
Copy link
Contributor

@zparnold: Closed this PR.

In response to this:

@oke-py sounds good, so that means the next time the docs are generated (1.14 release) this site will be updated. @jimangel can follow up with more (he's the release lead)
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants