Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis - Checkout the right K8s release and align on go version #13122

Closed
wants to merge 1 commit into from

Conversation

DanyC97
Copy link
Contributor

@DanyC97 DanyC97 commented Mar 12, 2019

Fixes #13121

cc @zacharysarah as per our last night slack chat

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ryanmcginnis

If they are not already assigned, you can assign the PR to them by writing /assign @ryanmcginnis in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 12, 2019
@DanyC97
Copy link
Contributor Author

DanyC97 commented Mar 12, 2019

⚠️ examples needs attention

@DanyC97 DanyC97 changed the title Travis - Checkout the right K8s releaes and align on go version Travis - Checkout the right K8s release and align on go version Mar 12, 2019
@netlify
Copy link

netlify bot commented Mar 12, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit d86fd1e

https://deploy-preview-13122--kubernetes-io-master-staging.netlify.com

@netlify
Copy link

netlify bot commented Mar 12, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit ba2890f

https://deploy-preview-13122--kubernetes-io-master-staging.netlify.com

@Bradamant3
Copy link
Contributor

cc @tengqm -- Qiming, do you have ideas here? Seems related to fixes to the examples tests you've provided in the past. (See also #sig-docs Slack)

@tengqm
Copy link
Contributor

tengqm commented Mar 12, 2019

Every release of k8s introduces some changes and/or refactoring that lead to test failure. The failure of this PR is expected and should be fixed. Need to examine the upstream code base to find out where the testing facility has been relocated.

@kbhawkey
Copy link
Contributor

Hello. After some searching, here is one package change:
ValidationDaemonSet
ValidationDeployment
...
https://github.com/kubernetes/kubernetes/blob/56735065400825d03f8e8f1a546c7a7b5ba9c5fd/pkg/apis/apps/validation/validation.go

@kbhawkey
Copy link
Contributor

@tengqm, I have not looked at the tests closely. Is this run for every build or only when an example changes. This area could use some documentation 👍

@DanyC97
Copy link
Contributor Author

DanyC97 commented Mar 12, 2019

is this run for every build or only when an example changes.

@kbarnard10 is run on every build i think - see https://github.com/kubernetes/website/blob/master/.travis.yml#L23-L26

@tengqm
Copy link
Contributor

tengqm commented Mar 12, 2019

@kbhawkey The test cases use to run on every build, before #11555 was merged. For all branches we maintain, we are supposed to use the correct version of go-lang and the correct version of upstream code for checking. This ensures that the examples we provide are usable for the version against which we have checked. I agree we should document this -- every time we create a dev-x.yz branch, we should adapt the travis CI job to use the latest versions of go-lang and upstream code. There could be changes that require revisions to the examples (thus the merits of the tests), e.g. beta version of resources got dropped, testing facility relocated etc.

@kbhawkey
Copy link
Contributor

Thanks for the explanation @tengqm.

  • Is there a way to automate this when a new docs dev branch is created? For example, this file would be updated on the docs 1.1.4 dev branch now?
  • The changes for 1.13 are retroactive and would be evaluated with package/build updates in this patch?

@zacharysarah zacharysarah mentioned this pull request Mar 12, 2019
2 tasks
tengqm added a commit to tengqm/website that referenced this pull request Mar 13, 2019
tengqm added a commit to tengqm/website that referenced this pull request Mar 13, 2019
@DanyC97
Copy link
Contributor Author

DanyC97 commented Mar 13, 2019

@tengqm i see you created a new PR in which case i'll close this PR in favour of yours

@DanyC97 DanyC97 closed this Mar 13, 2019
@DanyC97 DanyC97 deleted the update-travis branch March 13, 2019 11:45
k8s-ci-robot pushed a commit that referenced this pull request Mar 13, 2019
yagonobre pushed a commit to yagonobre/website that referenced this pull request Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants