Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference documentation for kube components #13444

Merged
merged 1 commit into from Mar 27, 2019

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented Mar 26, 2019

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 26, 2019
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Mar 26, 2019
@netlify
Copy link

netlify bot commented Mar 26, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 9a8fa16

https://deploy-preview-13444--kubernetes-io-master-staging.netlify.com

@DanyC97
Copy link
Contributor

DanyC97 commented Mar 26, 2019

@tengqm quick question (more for my own understanding): assuming #13117 gets in, i guess we can replace all the html code in the markdown file with the new shortcode, is that correct?

@jimangel
Copy link
Member

/hold

Thanks @tengqm for the fast work! I would like to test the instructions and validate from an outside perspective before merging this so you don't need to do this again in 3 months :)

ref: #13396

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2019
@tengqm
Copy link
Contributor Author

tengqm commented Mar 27, 2019

@DanyC97 Code for generating the table can be found here. We were generating HTML tables directly because:

  1. We want better control over the rendering of the table, see line 243-255 in the above file. This is not doable using plain markdown syntax.
  2. We prefer scrollable tables over verbatim dumps of help message because the latter is very difficult o read.
  3. Fortunately, we can embed HTML tables in markdown docs thanks to the markdown engine!

#13117 is solving a different problem regarding the syntax needed for markdown tables.

@jimangel
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 27, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jimangel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2019
@jimangel
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 27, 2019
@tengqm tengqm merged commit 8858299 into kubernetes:master Mar 27, 2019
@tengqm tengqm deleted the kubecomp-ref-1.14 branch March 27, 2019 07:58
@DanyC97
Copy link
Contributor

DanyC97 commented Mar 27, 2019

@tengqm many thanks for the info!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants