Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update api-conventions.md link references #13786

Merged
merged 1 commit into from Apr 15, 2019
Merged

Update api-conventions.md link references #13786

merged 1 commit into from Apr 15, 2019

Conversation

dpb587-pivotal
Copy link
Contributor

The target was moved to sig-architecture; this avoids the temporary landing page.

There are several thousand links in some *.html files (example), but those seem generated so I avoided changing those. Happy to add them to this PR if they would be good to change as well.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. language/en Issues or PRs related to English language language/ko Issues or PRs related to Korean language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Apr 11, 2019
@netlify
Copy link

netlify bot commented Apr 11, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 2d216a4

https://deploy-preview-13786--kubernetes-io-master-staging.netlify.com

@dpb587-pivotal
Copy link
Contributor Author

/assign @zacharysarah

@zacharysarah
Copy link
Contributor

/unassign

@tengqm
Copy link
Contributor

tengqm commented Apr 15, 2019

Many thanks for the fix.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2019
@k8s-ci-robot k8s-ci-robot merged commit 8db85ff into kubernetes:master Apr 15, 2019
McCoyAle pushed a commit to McCoyAle/website that referenced this pull request Apr 16, 2019
@dpb587-pivotal @McCoyAle
Update api-conventions.md link references (kubernetes#13786)
3d730de
nowjean pushed a commit to nowjean/website that referenced this pull request Jun 13, 2019
@dpb587-pivotal @nowjean
Update api-conventions.md link references (kubernetes#13786)
0863b0f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bprashanth bprashanth Awaiting requested review from bprashanth

@chenopis chenopis Awaiting requested review from chenopis

Assignees

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language language/ko Issues or PRs related to Korean language language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dpb587-pivotal @zacharysarah @tengqm @k8s-ci-robot