Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix orders of yaml of services-networking/service #14212

Merged
merged 1 commit into from May 8, 2019

Conversation

oomichi
Copy link
Member

@oomichi oomichi commented May 7, 2019

The orders of kind and metadata were inconsistent, and that made the
doc unreadable.
This fixes the orders in consistent way in service.md

ref: #13862

The orders of kind and metadata were inconsistent, and that made the
doc unreadable.
This fixes the orders in consistent way in service.md
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 7, 2019
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels May 7, 2019
@netlify
Copy link

netlify bot commented May 7, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 2d41150

https://deploy-preview-14212--kubernetes-io-master-staging.netlify.com

@Rajakavitha1
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Rajakavitha1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2019
@k8s-ci-robot k8s-ci-robot merged commit f952ac1 into kubernetes:master May 8, 2019
yoonian pushed a commit to yoonian/kubernetes-website that referenced this pull request May 28, 2019
The orders of kind and metadata were inconsistent, and that made the
doc unreadable.
This fixes the orders in consistent way in service.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants