Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in authentication.md #15721

Merged
merged 1 commit into from
Aug 7, 2019
Merged

Fix typo in authentication.md #15721

merged 1 commit into from
Aug 7, 2019

Conversation

johananl
Copy link
Contributor

@johananl johananl commented Aug 7, 2019

Change "certificates authorities" to "certificate authorities".

@johananl
Fix typo in authentication.md
8706e4f 
Change "certificates authorities" to "certificate authorities".
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 7, 2019
@netlify
Copy link

netlify bot commented Aug 7, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 8706e4f

https://deploy-preview-15721--kubernetes-io-master-staging.netlify.com

@k8s-ci-robot
Copy link
Contributor

@aimeeu: changing LGTM is restricted to collaborators

In response to this:

Thanks for the correction!
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

aimeeu
aimeeu reviewed Aug 7, 2019
View reviewed changes
Copy link
Contributor

@aimeeu aimeeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the correction! LGTM (this PR still needs review from a k8s member)

@thecrudge
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 7, 2019
@zacharysarah
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2019
@k8s-ci-robot k8s-ci-robot merged commit d3c216f into kubernetes:master Aug 7, 2019
@aimeeu aimeeu mentioned this pull request Aug 27, 2019
Closed
6 tasks
wahyuoi pushed a commit to wahyuoi/website that referenced this pull request Sep 9, 2019
@johananl @wahyuoi
Fix typo in authentication.md (kubernetes#15721)
10a3a90 
Change "certificates authorities" to "certificate authorities".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aimeeu aimeeu aimeeu left review comments

@deads2k deads2k Awaiting requested review from deads2k

@ericchiang ericchiang Awaiting requested review from ericchiang

Assignees

@thecrudge thecrudge

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@johananl @k8s-ci-robot @thecrudge @zacharysarah @aimeeu