Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZH-tarns:add namespaces.md #15784

Merged
merged 3 commits into from Aug 11, 2019

Conversation

@xichengliudui
Copy link
Contributor

commented Aug 10, 2019

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Remember to delete this note before submitting your pull request.

For pull requests on 1.15 Features: set Milestone to 1.15 and Base Branch to dev-1.15

For pull requests on Chinese localization, set Base Branch to release-1.14

For pull requests on Korean Localization: set Base Branch to dev-1.14-ko.<latest team milestone>

If you need Help on editing and submitting pull requests, visit:
https://kubernetes.io/docs/contribute/start/#improve-existing-content.

If you need Help on choosing which branch to use, visit:
https://kubernetes.io/docs/contribute/start#choose-which-git-branch-to-use.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

xichengliudui added some commits Aug 10, 2019

@markthink
Copy link
Member

left a comment

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link

commented Aug 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markthink

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7d199a6 into kubernetes:release-1.14 Aug 11, 2019

5 of 7 checks passed

tide Not mergeable.
Details
Pages changed 211 new files uploaded
Details
Header rules 1 header rule processed
Details
Mixed content No mixed content detected
Details
Redirect rules 1 redirect rule processed
Details
cla/linuxfoundation xichengliudui authorized
Details
deploy/netlify Deploy preview ready!
Details
{{% capture prerequisites %}}

* {{< include "federated-task-tutorial-prereqs.md" >}}
* 您还需要具备基本的 [Kubernetes 工作知识](/docs/tutorials/ Kubernetes -basics/),

This comment has been minimized.

Copy link
@chenrui333

chenrui333 Aug 11, 2019

Member

the hyperlink in here has some issue.


* {{< include "federated-task-tutorial-prereqs.md" >}}
* 您还需要具备基本的 [Kubernetes 工作知识](/docs/tutorials/ Kubernetes -basics/),
特别是[命名空间](/docs/concepts/overview/working- objects/ Namespaces /)。

This comment has been minimized.

Copy link
@chenrui333

chenrui333 Aug 11, 2019

Member

the hyperlink in here has some issue.

<!--
At this point, deleting a federated Namespace will not delete the corresponding Namespace, or resources in those Namespaces, from underlying clusters. Users must delete them manually. We intend to fix this in the future.
-->
此时,删除联邦命名空间不会从底层集群中删除相应的命名空间或这些命名空间中的资源。用户必须手动删除它们。我们打算将来解决这个问题。

This comment has been minimized.

Copy link
@chenrui333

chenrui333 Aug 11, 2019

Member

adding a comma like the original text would increase readability.

@chenrui333

This comment has been minimized.

Copy link
Member

commented Aug 11, 2019

Just to be clear, there are some issues with the hyperlink references.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.