Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to VolumeSnapshot CRD v1beta1 #15942

Merged
merged 1 commit into from
Sep 3, 2019
Merged

Change to VolumeSnapshot CRD v1beta1 #15942

merged 1 commit into from
Sep 3, 2019

Conversation

xing-yang
Copy link
Contributor

This PR changes VolumeSnapshot CRD version from v1alpha1 to v1beta1.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 19, 2019
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit 625da58

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5d5a9b2f0432820008638a5e

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Aug 19, 2019
@xing-yang xing-yang mentioned this pull request Aug 19, 2019
Closed
@xiangpengzhao
Copy link
Contributor

/assign @mistyhacks @jimangel

mdlinville
mdlinville reviewed Aug 20, 2019
View reviewed changes
Copy link
Contributor

@mdlinville mdlinville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

You need technical LGTM

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mistyhacks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2019
@xiangpengzhao
Copy link
Contributor

/cc @jingxu97 @msau42

@simplytunde
Copy link
Contributor

@xing-yang We need this PR ready for review before Sep 3.

@xing-yang xing-yang changed the title WIP: Change to VolumeSnapshot CRD v1beta1 Change to VolumeSnapshot CRD v1beta1 Aug 27, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 27, 2019
@xing-yang
Copy link
Contributor Author

@simplytunde, the content of this PR is ready, but we need to get the code merged before merging this doc PR.

@simplytunde
Copy link
Contributor

/milestone 1.16

@k8s-ci-robot k8s-ci-robot added this to the 1.16 milestone Aug 28, 2019
@xiangpengzhao
Copy link
Contributor

@xing-yang could you please ref the code PR here so that we can track the status of it? Thanks!

@xing-yang
Copy link
Contributor Author

This is delayed to 1.17. PR is here:
kubernetes/kubernetes#80058

sftim
sftim reviewed Sep 3, 2019
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @xing-yang
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 3, 2019
@k8s-ci-robot k8s-ci-robot merged commit 84b66ff into kubernetes:dev-1.16 Sep 3, 2019
@msau42
Copy link
Member

msau42 commented Sep 3, 2019 •
edited

@sftim we should not have merged this PR, as the feature is delayed to 1.17

@sftim
Copy link
Contributor

sftim commented Sep 3, 2019

Oops! Let me PR something to revert that.

@sftim
Copy link
Contributor

sftim commented Sep 3, 2019

🤦

@sftim sftim mentioned this pull request Sep 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdlinville mdlinville mdlinville left review comments

@sftim sftim sftim left review comments

@jsafrane jsafrane Awaiting requested review from jsafrane

@saad-ali saad-ali Awaiting requested review from saad-ali

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@msau42 msau42 Awaiting requested review from msau42

Assignees

@jimangel jimangel

@mdlinville mdlinville

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.16
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@xing-yang @k8sio-netlify-preview-bot @xiangpengzhao @k8s-ci-robot @simplytunde @msau42 @sftim @mdlinville @jimangel